-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean expressions of objective prerequisites #927
Conversation
081da8f
to
260d0b8
Compare
8105de4
to
57bb412
Compare
bf207d0
to
15dba40
Compare
77f82ab
to
4d02e64
Compare
1ec6c00
to
5e682d8
Compare
@kostmo do you plan to merge this as one commit or squash some of them? I will try to find some time to test this during the week. 🙂 |
There are a few worth preserving as distinct commits, but I'll squash the WIP commits. |
Note, the way we have Mergify set up, it always squashes merged PRs into a single commit. If you want to preserve things as distinct commits they have to be split out into multiple PRs. |
5e682d8
to
5c16451
Compare
5c16451
to
f988f5e
Compare
ed18e94
to
cc1151f
Compare
@kostmo thanks for testing my GitHub Action 😄 I am really happy it works and sorry it is bothering you. 😅 But at least you don't have to scroll through the comments to find it. 😉 |
Seems to work well! |
9c96c85
to
b1e9361
Compare
Co-authored-by: Brent Yorgey <byorgey@gmail.com>
48bab41
to
73690cd
Compare
@byorgey I think this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🚀 Looks great!
I noticed a small issue where scenarios with a condition
but no goal description etc. (e.g. the Speedrun
scenarios) pop up a tiny, empty box at the beginning. We can split that out into a separate issue. (Also, I should add goal descriptions to those Speedrun scenarios.)
Closes #795
Tasks
boolexpr
packageFor follow-up PRs:
boolexpr
to Hackage (perhaps take over the package?) (introduce boolexpr package to replace vendored module #1188)