Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce boolexpr package to replace vendored module #1188

Merged
merged 1 commit into from
Apr 1, 2023
Merged

introduce boolexpr package to replace vendored module #1188

merged 1 commit into from
Apr 1, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Apr 1, 2023 •
edited
Loading

Closes #934.

@restyled-io restyled-io bot mentioned this pull request Apr 1, 2023
Closed
@kostmo kostmo force-pushed the boolexpr-package branch from 58903a0 to e27d4e3 Compare April 1, 2023 03:13
@kostmo kostmo force-pushed the boolexpr-package branch from e27d4e3 to 6ee5f3d Compare April 1, 2023 03:38
@kostmo kostmo requested a review from byorgey April 1, 2023 03:56
@kostmo kostmo marked this pull request as ready for review April 1, 2023 03:56
byorgey
byorgey approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your work pushing things upstream!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Apr 1, 2023
@mergify mergify bot merged commit 6702a8b into main Apr 1, 2023
@mergify mergify bot deleted the boolexpr-package branch April 1, 2023 17:46
@kostmo kostmo mentioned this pull request Nov 21, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to manage "vendored" boolexpr dependency?
2 participants
@kostmo @byorgey