Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs other than goals dialog do not scroll #1068

Closed
byorgey opened this issue Jan 31, 2023 · 1 comment · Fixed by #1071
Closed

Dialogs other than goals dialog do not scroll #1068

byorgey opened this issue Jan 31, 2023 · 1 comment · Fixed by #1071
Labels
Bug The observed behaviour is incorrect or unexpected.

Comments

@byorgey
Copy link
Member

byorgey commented Jan 31, 2023

Describe the bug
Dialogs such as the Commands or Recipes dialogs have a scroll bar displayed, but cannot be scrolled.

To Reproduce

  1. Start a new Classic game.
  2. Press F4 to view the Commands dialog (make sure it does not fit in the window so a scrollbar is displayed).
  3. Try to scroll.

Additional context
I expect this has been caused by something related to #927, but I am not sure yet.
@byorgey byorgey added the Bug The observed behaviour is incorrect or unexpected. label Jan 31, 2023
@byorgey
Copy link
Member Author

byorgey commented Jan 31, 2023

OK, I did a git bisect, and this was actually caused by 17c2d8c, i.e. #1055 .

byorgey added a commit that referenced this issue Jan 31, 2023
@byorgey
also run handleInfoPanelEvent for dialogs other than GoalModal
ffd8906 
Fixes #1068.
@byorgey byorgey mentioned this issue Jan 31, 2023
Merged
@mergify mergify bot closed this as completed in #1071 Jan 31, 2023
@mergify mergify bot closed this as completed in a785f5f Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug The observed behaviour is incorrect or unexpected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

also run handleInfoPanelEvent for dialogs other than GoalModal swarm-game/swarm
1 participant
@byorgey