also run handleInfoPanelEvent for dialogs other than GoalModal
#1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
approved these changes
Jan 31, 2023
xsebek
approved these changes
Jan 31, 2023
| @@ -419,7 +419,7 @@ handleModalEvent = \case | |||
| uiState . uiGoal . listWidget .= newList | |||
| GoalSummary -> handleInfoPanelEvent modalScroll (VtyEvent ev) | |||
| _ -> handleInfoPanelEvent modalScroll (VtyEvent ev) | |||
| _ -> return () | |||
| _ -> handleInfoPanelEvent modalScroll (VtyEvent ev) | |||
There was a problem hiding this comment.
I almost wish we returned EventM Name AppState Bool to indicate whether the event was handled or fell through.
Then the top handler would know to call the next handler that might be interested.
There was a problem hiding this comment.
A Bool doesn't really sound like it would help that much, it would just be one more thing to get wrong...
What we should REALLY do is have an effect system for tracking a type-level list of unhandled events! 😜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068.