Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devices/entities with no recipe #1268

Open
2 of 5 tasks
byorgey opened this issue May 18, 2023 · 3 comments
Open
2 of 5 tasks

Devices/entities with no recipe #1268

byorgey opened this issue May 18, 2023 · 3 comments
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Design An issue having to do with game design. G-Entities An issue having to do with game entities. G-Recipes An issue having to do with recipes. Z-Feature A new feature to be added to the game.

Comments

@byorgey
Copy link
Member

byorgey commented May 18, 2023 •
edited by noahyor
Loading

This is a new umbrella issue for entities or devices without a recipe. Eventually we should create recipes so the entities are craftable in classic mode.

See #26 for an older version of this issue.
@byorgey byorgey added Z-Feature A new feature to be added to the game. C-Low Hanging Fruit Ideal issue for new contributors. G-Entities An issue having to do with game entities. G-Recipes An issue having to do with recipes. labels May 18, 2023
@kostmo kostmo added the G-Design An issue having to do with game design. label May 30, 2023
@xsebek
Copy link
Member

xsebek commented Oct 2, 2023

Just so we don't miss any, we could have integration tests that all entities are craftable from entities present in the classic world.

Those named here could be an exception marked with “expected fail”. Adding recipes would then give the good feeling of making tests green. 😄

@xsebek
Copy link
Member

xsebek commented Oct 2, 2023

I am surprised we don’t have hourglass made from sand, wood and glass, which we all have.

Not sure if that seemed too easy for wait?

@byorgey
Copy link
Member Author

byorgey commented Oct 2, 2023

we could have integration tests that all entities are craftable from entities present in the classic world.

That sounds like a great idea!

I am surprised we don’t have hourglass made from sand, wood and glass, which we all have. Not sure if that seemed too easy for wait?

No, that sounds good to me! I don't think it needs to be that difficult to obtain wait.

@kostmo kostmo mentioned this issue Dec 6, 2023
Merged
mergify bot pushed a commit that referenced this issue Dec 12, 2023
@kostmo
unit test for recipe coverage (#1676)
36a0046 
Towards #1268

## Demo

    scripts/run-tests.sh --test-arguments '--pattern "Recipe coverage"'
This was referenced Jun 11, 2024
Open
Open
This was referenced Jul 10, 2024
Closed
Merged
mergify bot pushed a commit that referenced this issue Jul 13, 2024
@noahyor
Rolex, Olfactometer, and Dozer Blade Recipes (#2028)
70370f8 
Moving towards finishing #1813 and #1268.
mergify bot pushed a commit that referenced this issue Jul 13, 2024
@xsebek
Recipe coverage graph test (#2030)
9504996 
* Use the recipe graph to find unreachable entities instead of only looking for recipes for devices.
  * Improves on #1676.
* Add yielded entities in the recipe graph
* Add a test for each entity.

Before:
```
   Recipe coverage
    Ensure all devices have recipes (#1268):                                            FAIL (expected: Need to come up with more recipes)
      test/unit/TestRecipeCoverage.hs:36:
      Missing recipes for: "Elmer's glue", "binoculars", "blueprint", "caliper", "decoder ring", "dozer blade", "hourglass", "lambda", "linotype", "olfactometer", "rolex", "tape drive", and "wedge" (expected failure)
```
After
```
  Ensure all entities have recipes
    3D printer:                   OK
    ADT calculator:               OK
    Elmer's glue:                 FAIL (expected: More recipes needed (#1268))
      test/integration/TestRecipeCoverage.hs:34:
      Can not make "Elmer's glue" from starting entities. (expected failure)
    [... 100 more entities ...]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Design An issue having to do with game design. G-Entities An issue having to do with game entities. G-Recipes An issue having to do with recipes. Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kostmo @byorgey @xsebek