Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve module placement within scenario/engine sublibraries #1741

Closed
kostmo opened this issue Jan 24, 2024 · 0 comments · Fixed by #1743
Closed

Improve module placement within scenario/engine sublibraries #1741

kostmo opened this issue Jan 24, 2024 · 0 comments · Fixed by #1743
Labels
Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.

Comments

@kostmo
Copy link
Member

kostmo commented Jan 24, 2024 •
edited
Loading

Following up on #1719:

  • Swarm.Game.ScenarioInfo, Swarm.Game.Tick, and Swarm.Game.Scenario.Status could probably be moved from swarm-scenario to swarm-engine.
@kostmo kostmo added Z-Feature A new feature to be added to the game. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. and removed Z-Feature A new feature to be added to the game. labels Jan 24, 2024
@kostmo kostmo mentioned this issue Jan 24, 2024
Merged
mergify bot pushed a commit that referenced this issue Jan 24, 2024
@kostmo
move activity counts into swarm-engine (#1742)
3720e94 
Towards #1741
@kostmo kostmo mentioned this issue Jan 25, 2024
Merged
@mergify mergify bot closed this as completed in #1743 Jan 26, 2024
mergify bot pushed a commit that referenced this issue Jan 26, 2024
@kostmo
Improve separation of engine and scenario sublibraries (#1743)
101b17c 
Closes #1741

Remaining blocker was to move logging to concrete robot.

Most notably, the `swarm-scenario` sublibrary has been purged of its temporal component, corroborated by the removal of the `time` package dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve separation of engine and scenario sublibraries swarm-game/swarm
1 participant
@kostmo