Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart constructor for Grid #1981

Open
kostmo opened this issue Jun 24, 2024 · 0 comments
Open

smart constructor for Grid #1981

kostmo opened this issue Jun 24, 2024 · 0 comments
Labels
Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.

Comments

@kostmo
Copy link
Member

kostmo commented Jun 24, 2024 •
edited
Loading

Should have a "smart constructor" that enforces the invariant that all rows are equal length.

Later, if we create a separate EmptyGrid constructor (#1843), this can also ensure that the alternative has nonempty rows.
@kostmo kostmo added Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. labels Jun 24, 2024
@kostmo kostmo mentioned this issue Jun 24, 2024
Merged
mergify bot pushed a commit that referenced this issue Jun 25, 2024
@kostmo
remove 'unGrid' accessor (#1982)
6801cdd 
Towards #1981
@kostmo kostmo mentioned this issue Jun 29, 2024
Merged
mergify bot pushed a commit that referenced this issue Jul 1, 2024
@kostmo
nonempty grid rows (#1933)
9a5fe48 
Closes #1843

Towards #1981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kostmo