Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename robot type to be more inclusive #931

Closed
byorgey opened this issue Dec 21, 2022 · 4 comments · Fixed by #920
Closed

Rename robot type to be more inclusive #931

byorgey opened this issue Dec 21, 2022 · 4 comments · Fixed by #920
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Robots An issue having to do with robots. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@byorgey
Copy link
Member

byorgey commented Dec 21, 2022

Internally to the game implementation, anything that runs a program is a "robot". However, to the player, there are robots (things they build and program), and there can also be other kind of active things like aliens, animals, ... In particular I'm thinking about the meet command which will return a robot value (see #920), but you should be able to use it to meet aliens, animals, etc. So I'm wondering if we want to change the name of the robot type to something more generic and inclusive, and I'm open to suggestions what we should change it to. agent? actor? creature? being?

@byorgey byorgey added Z-User Experience This issue seeks to make the game more enjoyable to play. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. G-Robots An issue having to do with robots. labels Dec 21, 2022
@byorgey
Copy link
Member Author

byorgey commented Dec 21, 2022

I'm kind of leaning towards agent. creature and being seem to imply something is alive, so applying them to robots feels weird. agent is short and has a nice generic sense of "something that does something". There's also precedent for using "agent" within computing/programming contexts (e.g. agent-oriented programming, agent-based modelling, etc.).

@xsebek
Copy link
Member

xsebek commented Dec 21, 2022

I like actor for anything that “acts”.

Internally it will make a little more sense for seed actors. It makes it sound like the whole game is a theater play which kind of fits the simulation. 🙂

I'm fine with being too, agent feels like something from action movie but I would get used to it.

@xsebek
Copy link
Member

xsebek commented Dec 21, 2022

@byorgey do you also want to rename internal module, types and functions or only the in game type for “robot reference”?

@byorgey
Copy link
Member Author

byorgey commented Dec 21, 2022

OK, I like actor too. No, I was not thinking of renaming any internal modules, types, or functions, only the in game "robot reference" type. I suppose I could be convinced otherwise, but it would be a lot more work and I don't know what the benefit would be.

byorgey added a commit that referenced this issue Dec 21, 2022
@mergify mergify bot closed this as completed in #920 Dec 22, 2022
mergify bot pushed a commit that referenced this issue Dec 22, 2022
Closes #306. Closes #931.

- Renamed `robot` type to `actor` in anticipation of meeting other things besides robots.
- `meet : cmd (unit + actor)` returns an arbitrary actor within Manhattan distance 1, if any.
- `meetAll : (b -> actor -> cmd b) -> b -> cmd b` will run on every nearby actor.
- Added `antenna` device to provide the commands.
- Added "make a friend" challenge that requires the use of `meet`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Robots An issue having to do with robots. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants