Offload subrecords of GameState to other modules #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
added
the
Z-Refactoring
kostmo
force-pushed
the
refactor/offload-sub-state-records
branch
from
abd1bf5 to
6a0a960
Compare
Introduce 'zoomRobots' so that applicable functions can operate directly on 'Robots' state instead of 'GameState'.
kostmo
force-pushed
the
refactor/offload-sub-state-records
branch
from
6a0a960 to
31691b5
Compare
byorgey
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Looks good to me. My only minor gripe is that the name Swarm.Game.State.Substate seems rather generic. But I don't have any better suggestions. I suppose the alternative would be to make lots of tiny Swarm.Game.State.X modules, one for each substate record X, but that sounds tedious.
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2023
A continuation of #1667. * Do not export `_viewCenter` or `_focusedRobotID` * Move record initialization code to `Robot.hs` as `setRobotInfo`. * `modifyViewCenter`, `unfocus`, `recalcViewCenter` now operate directly on `Robots` instead of `GameState`.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1652 and towards #707.
Most of the sub-records are bundled into
Swarm.Game.State.Substate, but we create aSwarm.Game.State.Robotmodule just for robots.We introduce a
zoomRobotsfunction so that applicable functions can operate directly onRobotsstate instead ofGameState.Size comparison
Before
State.hsAfter
State.hsSubstate.hsRobot.hsConfig.hsFor follow-up PR:
_viewCenterand_focusedRobotIDfromSwarm.Game.State.Robot