Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract game engine sublibrary #1714

Merged
merged 2 commits into from
Jan 5, 2024
Merged

extract game engine sublibrary #1714

merged 2 commits into from
Jan 5, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 5, 2024 •
edited
Loading

Towards #1043

Extracts Swarm.Game.* modules to their own sublibrary.

There was already pretty good separation along this boundary; just had to move three functions into a new module Swarm.Util.Content.

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Jan 5, 2024
@kostmo kostmo requested a review from byorgey January 5, 2024 02:53
@kostmo kostmo marked this pull request as ready for review January 5, 2024 02:53
@kostmo kostmo mentioned this pull request Jan 5, 2024
Closed
byorgey
byorgey approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we at this point also edit the description in the .cabal file to talk about the sublibraries instead of saying "roughly the following layers"?

src/swarm-engine/Swarm/Util/Content.hs Show resolved Hide resolved
src/swarm-engine/Swarm/Util/Content.hs Show resolved Hide resolved
@kostmo kostmo force-pushed the refactor/extract-engine-sublibrary branch from 072f649 to 692fb78 Compare January 5, 2024 18:14
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jan 5, 2024
@mergify mergify bot merged commit 3cfc3c4 into main Jan 5, 2024
9 checks passed
@mergify mergify bot deleted the refactor/extract-engine-sublibrary branch January 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey