Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type family for RobotContext field #1732

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Use type family for RobotContext field #1732

merged 2 commits into from
Jan 20, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 16, 2024 •
edited
Loading

Continuation of #1731.

Towards #1715 and #1043.

This refactoring step is a prerequisite for #1719 to extricate references to the CESK module from the base RobotR definition.

In this PR:

  • Extracts the RobotContext type to a new module
  • Introduces a type family for the RobotContext field

@kostmo kostmo changed the title Use type family for field Use type family for RobotContext field Jan 16, 2024
@kostmo kostmo marked this pull request as ready for review January 16, 2024 18:47
@kostmo kostmo requested a review from byorgey January 16, 2024 18:47
byorgey
byorgey approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Sorry for the delay in looking at this, the semester just started and we had snow and super low temps that caused the college and public schools to be closed for a few days so it has been a crazy week 😅

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jan 20, 2024
@mergify mergify bot merged commit 9320a98 into main Jan 20, 2024
9 checks passed
@mergify mergify bot deleted the refactor/extract-robot-context branch January 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey