Support GHC 9.8, bump upper bounds, and update CI #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support GHC 9.8 (`base-4.19`) - `lsp-2.6` - `containers-0.7` - `lens-5.3` - `linear-1.23` - `time-1.14` - `wai-app-static-3.1.9` - `template-haskell-2.21` - `QuickCheck-2.15`
byorgey
changed the title
kostmo
approved these changes
May 10, 2024
| @@ -50,7 +50,7 @@ data AbsoluteDir = DEast | DNorth | DWest | DSouth | |||
| deriving (Eq, Ord, Show, Read, Generic, Data, Hashable, Enum, Bounded) | |||
|
|
|||
| directionJsonModifier :: String -> String | |||
| directionJsonModifier = map C.toLower . L.tail | |||
| directionJsonModifier = map C.toLower . L.drop 1 | |||
There was a problem hiding this comment.
Yeah, that's an easy one. There's nothing like drop to replace head, but https://github.com/haskell/core-libraries-committee/blob/main/guides/warning-for-head-and-tail.md had some good ideas, including the idea to replace uses of head with a locally-defined version that pattern-matches and calls error explicitly. That avoids the warning and also generates a better error message in case it ever does actually crash.
|
Whew, glad to finally get this done, I've been working on it all day! Updates like this always end up taking longer than I think... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure Swarm builds with the most recent versions of dependencies. The only one that is still lagging is
filepath, butservantdoesn't supportfilepath-1.5so Swarm can't either.The only real update needed was due to some breaking changes in
aeson-2.2, but the necessary changes were very minor.Also update our CI:
haskell-cirecently dropped support forhlint, in favor of projects defining their own standalonehlintworkflows.