Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure placement order #1833

Merged
merged 4 commits into from
May 10, 2024
Merged

structure placement order #1833

merged 4 commits into from
May 10, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented May 10, 2024

Towards #1780.

It is more intuitive in scenario design for "later" things to be placed "on top of" earlier things.

There were only a small number of scenarios for which placement order was relevant, so I fixed them.

@kostmo kostmo added the Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. label May 10, 2024
@kostmo kostmo requested a review from byorgey May 10, 2024 19:15
@kostmo kostmo force-pushed the bugfix/placement-order branch from 68dfddb to 405cbbd Compare May 10, 2024 19:16
@kostmo kostmo marked this pull request as ready for review May 10, 2024 19:18
@kostmo kostmo mentioned this pull request May 10, 2024
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more intuitive in scenario design for "later" things to be placed "on top of" earlier things.

I agree!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label May 10, 2024
@mergify mergify bot merged commit 5ed37d6 into main May 10, 2024
13 checks passed
@mergify mergify bot deleted the bugfix/placement-order branch May 10, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants