Fix Lazy IO opening too many files in integration tests #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run on macOS, the integration tests open too many file handles, even when you do not need to run any of the swarm file tests. ``` > cabal run -O0 swarm-integration -- -p editors swarm-integration: data/scenarios/Challenges/_bucket-brigade/hauler.sw: openFile: resource exhausted (Too many open files) ``` The solution is to only get the file paths and safely open them as needed.
Co-authored-by: Restyled.io <commits@restyled.io>
|
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
I have seen the `479-atomic-race` integration test timeout several times recently (most recently in #1917). Increase the timeout for that test from the default 1s to 2s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on macOS, the integration tests open too many file handles,
even when you do not need to run any swarm file tests.
> cabal run -O0 swarm-integration -- -p editors swarm-integration: data/scenarios/Challenges/_bucket-brigade/hauler.sw: openFile: resource exhausted (Too many open files)The solution is to get the file paths only and safely open them as needed.
Surprisingly, this even makes the integration test code simpler.