Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically insert matching close brackets at REPL #1953

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Automatically insert matching close brackets at REPL #1953

merged 3 commits into from
Jun 18, 2024

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jun 17, 2024

Closes #1952. Whenever you type (, [, or { at the REPL, a matching close bracket is automatically inserted.

I suppose the next level would be to have it delete both brackets if you hit backspace immediately after inserting an open bracket, but I'll leave that for another PR. Doesn't seem that important anyway.

@restyled-io restyled-io bot mentioned this pull request Jun 17, 2024
Merged
@byorgey byorgey requested a review from noahyor June 17, 2024 21:09
@restyled-io @restyled-commits
Restyled by fourmolu (#1954)
3efc228 
Co-authored-by: Restyled.io <commits@restyled.io>
noahyor
noahyor approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@noahyor noahyor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I love this feature!

nitinprakash96
nitinprakash96 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@nitinprakash96 nitinprakash96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jun 18, 2024
@mergify mergify bot merged commit de12501 into main Jun 18, 2024
11 checks passed
@mergify mergify bot deleted the push-mrnsmwtpvytk branch June 18, 2024 14:28
@byorgey byorgey added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jun 23, 2024
@byorgey byorgey mentioned this pull request Oct 12, 2024
Closed
@byorgey byorgey mentioned this pull request Nov 25, 2024
Merged
mergify bot pushed a commit that referenced this pull request Nov 28, 2024
@byorgey
Don't insert extra close bracket when the cursor is already on top of…
c7678f3 
… one (#2215)

Closes #2171.

When the cursor is on top of a close bracket (either `)`, `]`, or `}`) and the user types the same character, simply move the cursor right one position instead of inserting a new close bracket character.  This works especially well in conjunction with #1953.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahyor noahyor noahyor approved these changes

@nitinprakash96 nitinprakash96 nitinprakash96 approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing open bracket at the REPL should insert matching close bracket
3 participants
@byorgey @nitinprakash96 @noahyor