Save current REPL input with down arrow #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsebek
approved these changes
Jun 30, 2024
Haha, I actually thought about that. I think I'll wait to merge this until after your keybindings PR - it might be easier for me to resolve the conflicts in a smaller PR, and I still have to fix up the test suite anyway. |
Oh, nice! 🎉 I knew we were coming up on 2000 but hadn't noticed this was it. |
|
@byorgey, thanks for waiting for me. Good luck with the rebase. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #713.
Also does a bit of refactoring:
REPLHistIteminto aREPLHistItemTypeand someTextinstead of having multiple constructors all containing aTextController.Utilto cut down on duplicated code