Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move more recognizer logic into topography sublibrary #2021

Merged
merged 2 commits into from
Jul 14, 2024
Merged

move more recognizer logic into topography sublibrary #2021

merged 2 commits into from
Jul 14, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jul 9, 2024 •
edited
Loading

Builds upon #1836.

This PR moves functions that are independent of Entity type into a new module within swarm-topography, alongside most of the other structure recognizer code. Notably, this allows removal of the AhoCorasick dependency from the swarm-scenario sublibrary.

@restyled-io restyled-io bot mentioned this pull request Jul 9, 2024
Closed
@kostmo kostmo force-pushed the refactor/extract-more-recognizer-logic branch from 489505f to abbe627 Compare July 9, 2024 05:27
@kostmo kostmo force-pushed the refactor/extract-more-recognizer-logic branch from abbe627 to 5a7172f Compare July 14, 2024 00:17
@kostmo kostmo marked this pull request as ready for review July 14, 2024 00:18
@kostmo kostmo requested a review from byorgey July 14, 2024 00:18
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Jul 14, 2024
@kostmo kostmo mentioned this pull request Jul 14, 2024
Merged
byorgey
byorgey approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jul 14, 2024
@mergify mergify bot merged commit 33d38c9 into main Jul 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey