Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for hourglass #2025

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Add recipe for hourglass #2025

merged 1 commit into from
Jul 12, 2024

Conversation

noahyor
Copy link
Member

@noahyor noahyor commented Jul 11, 2024

Closes #2023.

@noahyor noahyor requested review from byorgey and xsebek July 11, 2024 19:23
@noahyor
Copy link
Member Author

noahyor commented Jul 11, 2024

I probably need to change the CI too, but I will wait for it to finish first.

xsebek
xsebek approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

What do you mean by the CI change?

@noahyor
Copy link
Member Author

noahyor commented Jul 12, 2024

Never mind. I thought the CI would fail because the expected failure would be different from the actual failure.

@noahyor noahyor added the merge me Trigger the merge process of the Pull request. label Jul 12, 2024
@mergify mergify bot merged commit 4838d5e into main Jul 12, 2024
10 checks passed
@mergify mergify bot deleted the recipe/hourglass branch July 12, 2024 16:24
@xsebek xsebek mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

@byorgey byorgey Awaiting requested review from byorgey

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a recipe for the hourglass
2 participants
@noahyor @xsebek