-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliminate remaining Cell dependence in structure recognizer #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
changed the title
[WIP] improve logging details for shape recognition
[WIP] eliminate remaining Cell dependence in structure recognizer
Aug 13, 2024
kostmo
force-pushed
the
feature/improve-recognition-logging
branch
from
August 13, 2024 07:17
e6b6da2
to
4aaed80
Compare
kostmo
changed the title
[WIP] eliminate remaining Cell dependence in structure recognizer
eliminate remaining Cell dependence in structure recognizer
Aug 13, 2024
kostmo
added
the
Z-Refactoring
This issue is about restructuring the code without changing the behaviour to improve code quality.
label
Aug 13, 2024
byorgey
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge me
Trigger the merge process of the Pull request.
Z-Refactoring
This issue is about restructuring the code without changing the behaviour to improve code quality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #1836.
Ultimately, this allows us to move the final remaining module,
Precompute.hs
, into theswarm-topology
sublibrary to live alongside the rest of the structure recognizer code.Also in this PR