Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TyDef narrowToPosition #2170

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Fix TyDef narrowToPosition #2170

merged 3 commits into from
Oct 12, 2024

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Oct 12, 2024 •
edited
Loading

STyDef is not actually an atom and we need to recurse further.

Recursing TyDef
false tydef

Closes #2169.

@xsebek
Fix TyDef narrowToPosition
e7da47c 
`STyDef` is not actually an atom and we need to recurse further.
@xsebek xsebek added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Oct 12, 2024
@xsebek xsebek self-assigned this Oct 12, 2024
byorgey
byorgey approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, good catch. It used to be an atom, but that changed in #1928 .

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Oct 12, 2024
@mergify mergify bot merged commit 188ff6b into main Oct 12, 2024
12 checks passed
@mergify mergify bot deleted the task/xsebek/tydef-hover branch October 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees

@xsebek xsebek

Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type definition breaks LSP hover
2 participants
@xsebek @byorgey