Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use applyWhen #2180

Merged
merged 1 commit into from
Oct 15, 2024
Merged

use applyWhen #2180

merged 1 commit into from
Oct 15, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 15, 2024

Continuing with the replacements started in this discussion: #2140 (comment)

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Oct 15, 2024
@kostmo kostmo force-pushed the refactor/apply-when branch from b1eeb23 to caaf8fe Compare October 15, 2024 04:04
@kostmo kostmo force-pushed the refactor/apply-when branch from caaf8fe to e0bc8ec Compare October 15, 2024 04:15
@kostmo kostmo requested review from byorgey and xsebek October 15, 2024 05:15
@kostmo kostmo marked this pull request as ready for review October 15, 2024 05:15
byorgey
byorgey approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we used if ... then ... else id so much!

@xsebek
Copy link
Member

xsebek commented Oct 15, 2024

@kostmo could we have a HLint rule to prevent adding it again?

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 15, 2024
@mergify mergify bot merged commit 6ae956b into main Oct 15, 2024
12 checks passed
@mergify mergify bot deleted the refactor/apply-when branch October 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostmo @xsebek @byorgey