Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autopause on complete game #2181

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix autopause on complete game #2181

merged 2 commits into from
Oct 18, 2024

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Oct 15, 2024

@xsebek xsebek requested a review from kostmo October 15, 2024 18:16
@xsebek xsebek self-assigned this Oct 15, 2024
@xsebek xsebek requested a review from byorgey October 15, 2024 18:16
@xsebek
Copy link
Member Author

xsebek commented Oct 15, 2024

@kostmo, I think you added the goal logic. Could you please check if the new pause condition is correct?

byorgey
byorgey approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although thinking about the pausing logic always makes my brain hurt.

kostmo
kostmo approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it fixes the observed bug.

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Oct 18, 2024
@mergify mergify bot merged commit d30cd6a into main Oct 18, 2024
12 checks passed
@mergify mergify bot deleted the task/xsebek/2174-fix-pause-complete branch October 18, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@kostmo kostmo kostmo approved these changes

Assignees

@xsebek xsebek

Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After selecting "Keep playing", game gets re-paused upon every keypress
3 participants
@xsebek @kostmo @byorgey