ensure no overlaps in initial placement of recognized structures

[kostmo]

Implements overlap resolution for pre-placed recognized structures.

Also introduces a NonEmptyGrid type, towards #2004.

Testing

scripts/play.sh --scenario data/scenarios/Testing/1575-structure-recognizer/2201-initial-recognition-overlap.yaml --autoplay

Other changes

• Enrich structure logging (e.g. OriginalName -> OrientedStructure)
• Consolidate record fields (e.g. in LocatedStructure)
• Introduce zipNumberedNE function
• Rename some functions (e.g. mapIndexedMembers -> mapWithCoords)
• Use StructureName, remove OriginalName

[xsebek]

Why does the overlap need to be detected? Does the structure recognition algorithm only find one?

[xsebek]

I don't follow. What are those criteria? A link to another comment or function would be helpful.

[kostmo]

Added more comments and cross-references.

[kostmo]

Why does the overlap need to be detected? Does the structure recognition algorithm only find one?

While the game is being played, the structure recognition algorithm ensures that only one of potentially multiple overlapping structures will be recognized. However, at game state initialization time, we're not actually running the structure recognition automata. Instead we simply check all the locations of pre-placed structures and ensure they are still intact, given potential overlapping placements. Importantly, two structures could overlap but still be independently "intact"; this PR adds logic to ensure mutual-exclusivity.

[byorgey]

Suggested change

	newtype StructureName = StructureName Text
	newtype StructureName = StructureName { getStructureName :: Text }

Then we don't need the separate declaration of getStructureName.

[kostmo]

This results in some kind of JSON parse error I've yet to look into.

[byorgey]

Hmm, weird. Well, don't worry about it then, it's not a big deal.

[kostmo]

Would you like to approve this, @byorgey?

[byorgey]

Yes, sorry, thanks for the nudge!