Generalize challenges + classic/creative modes to scenarios #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very open to suggestions/improvements/other ideas!
In preparation for generalizing challenges as outlined in #296.
The goal is to be able to load e.g. the classic game as a scenario.
There is no longer a separate special "classic" mode; it is just one of the possible scenarios.
Also edit the classic scenario so it better matches what the baseRobot function was doing. Only remaining thing to do is to restore the functionality of --run (which the baseRobot function was handling).
Dangerous because we almost never want to use it: we want to keep around the old store and/or environment.
Note we now have what #312 (comment) hinted at, where `--run` works in any scenario, not just classic mode, since we have merged classic and challenge modes into the more generic "scenario" framework. This still suffers from #333, but that bug already existed before, so I'm leaving it to be fixed separately.
Also, do the loading inside `initGameState`, instead of passing a weird monadic callback function parameter to it.
|
There's always more that can be done, but I think this is definitely ready for review & merge, and we can create issues to track the stuff remaining to do. See #296 for some related things still to do. Other than that, off the top of my head:
|
|
@xsebek , I know this is a large change, but if you get a chance I'd love your thoughts on this! |
xsebek
approved these changes
Jun 3, 2022
| continue $ | ||
| s & uiState . uiMenu | ||
| .~ NewGameMenu (NE.fromList [mkScenarioList (s ^. gameState . scenarios)]) | ||
| Tutorial -> continue $ s & uiState . uiMenu .~ TutorialMenu |
There was a problem hiding this comment.
Is this still well placed when the tutorials are in the New game?
There was a problem hiding this comment.
Well, my idea was as follows:
- Once we create "meta-scenarios" which can consist of a sequence of other scenarios, The Tutorial will be such a thing. See Improvements to challenge mode #296 and Tutorial via challenge mode #25 .
- We want the tutorial to be very prominently placed in the top-level menu, so someone just starting the game for the first time will immediately know how to start a tutorial. Selecting that top-level Tutorial menu item will automatically load the meta-scenario consisting of the sequence of tutorial scenarios.
- However, it will still be possible to load individual tutorial scenarios through the New Game menu and selecting one manually.
There was a problem hiding this comment.
Sure, maybe we could leave a note that the tutorial is being slowly constructed over in the New game section?
In the meantime, you can play through a few tutorial parts over in the New game menu.
|
@xsebek thanks for the many great suggestions! I think I've addressed almost all of them now, what do you think? |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize challenges + various modes to all be "scenarios" which are described by
.yamlfiles indata/scenarios..yamlfile indata/scenarios.See #296. This will enable #35 and #25 .