Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sand, glass, and calculator #362

Merged
merged 5 commits into from
Jun 6, 2022
Merged

add sand, glass, and calculator #362

merged 5 commits into from
Jun 6, 2022

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jun 4, 2022

  • Sand is now found near water. Sand regenerates immediately (like water).
  • Sand can be used in a furnace to make glass.
  • Glass + copper wires + 3D printer can be used to make solar panels.
  • Solar panel + counter can be used to make a calculator.

@byorgey
Copy link
Member Author

byorgey commented Jun 4, 2022

Once people are happy with this we should also think about whether the tutorial needs to be updated.

@byorgey byorgey linked an issue Jun 4, 2022 that may be closed by this pull request
@byorgey
Copy link
Member Author

byorgey commented Jun 4, 2022

At #336 we also discussed the possibility of being able to create sand by drilling rocks; we could easily add that later.

As described in
#26 (comment)

`calculator` device provides `arith` capability.
@byorgey byorgey changed the title add sand (found near water) and glass add sand, glass, and calculator Jun 4, 2022
data/entities.yaml Outdated Show resolved Hide resolved
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once people are happy with we should also think about whether the tutorial needs to be updated.

With what? Otherwise, this looks good to me. 👍

- name: sand
display:
attr: copper
char: '░'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I can not see the character very well. Maybe its the dirt background and copper attribute?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the name of the character is "light shade" and my font takes that literally:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same character used for dirt, grass, and stone, but should be the same color as copper. I do want to make sure it's distinguishable in different terminals which don't all handle color the same...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in my terminal the copper and dirt colors are easily distinguishable. But I tried it in gnome-terminal and the two colors are very very hard to tell apart. Any suggestions for a different color and/or character to use?

Copy link
Member

@xsebek xsebek Jun 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest IceT background and the sand attribute which I completely forgot about. 😄

No idea what I used sand for half a year ago:

, (sandAttr, fg (V.rgbColor @Int 194 178 128)) -- Ondřej Šebek, 8 months ago Add drill command (#186)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, didn't know we had a sand attribute! I updated it, how does it look now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough, in light colour schemes it very much looks like sand for me, in dark ones it's a bit muddy but still distinguishable. 👍

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jun 6, 2022
@mergify mergify bot merged commit 7b4ffcc into main Jun 6, 2022
@mergify mergify bot deleted the sand branch June 6, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sand entity
2 participants