Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from U+2591 Light Shade to U+2592 Medium Shade #449

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jun 20, 2022

Some terminals (e.g. gnome-terminal) use the character to decide
how dark or light the color should be, rather than showing the
character itself (like e.g. rxvt-unicode). Light Shade looks OK
in terminals that display the actual character, but too dark in
terminals that use it as a brightness hint. Medium Shade seems to
look good (at least, IMO) in both.

See #196 (comment) .

Some terminals (*e.g.* `gnome-terminal`) use the character to decide
how dark or light the color should be, rather than showing the
character itself (like *e.g.* `rxvt-unicode`).  Light Shade looks OK
in terminals that display the actual character, but too dark in
terminals that use it as a brightness hint.  Medium Shade seems to
look good (at least, IMO) in both.

See
#196 (comment) .
@byorgey byorgey requested a review from xsebek June 20, 2022 15:13
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look a bit more colourful 👍 I will have to try urxvt someday. 🙂

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jun 20, 2022
@mergify mergify bot merged commit 8b8c16a into main Jun 20, 2022
@mergify mergify bot deleted the medium-shade branch June 20, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants