Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy parent robot context to child when executing build #817

Merged
merged 1 commit into from
Nov 2, 2022
Merged

copy parent robot context to child when executing build #817

merged 1 commit into from
Nov 2, 2022

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Nov 2, 2022

Fixes #394.

xsebek
xsebek approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I am surprised that the robots even worked. 🤯

@byorgey
Copy link
Member Author

byorgey commented Nov 2, 2022

I was too at first, but I posted an explanation over at #394.

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Nov 2, 2022
@mergify mergify bot merged commit e378fbf into main Nov 2, 2022
@mergify mergify bot deleted the fix/issue-394 branch November 2, 2022 20:26
@kostmo kostmo mentioned this pull request Jan 16, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
@kostmo
Remove superfluous trobotContext lens (#1731)
40ea471 
# Motivation

Want to remove dependence of `TRobot` on the `RobotContext` record.  However, a lens `trobotContext` had been added in #817 to fix #394.

# Test

    scripts/run-tests.sh --test-arguments '--pattern "394-build-drill"'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inner build does not correctly require Drill
2 participants
@byorgey @xsebek