Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract utils from Controller and View #881

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Extract utils from Controller and View #881

merged 2 commits into from
Dec 12, 2022

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 5, 2022 •
edited
Loading

Just like #880, this refactoring is in anticipation of #873 (see comment) for ease of review, and there are no functional changes in this PR.

Also towards #707.

@kostmo kostmo requested review from TristanCacqueray, byorgey and xsebek and removed request for TristanCacqueray December 5, 2022 03:46
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Dec 5, 2022
@kostmo kostmo force-pushed the view-and-controller-splits branch from 0a9d2b9 to b38e88a Compare December 8, 2022 04:18
@restyled-io restyled-io bot mentioned this pull request Dec 8, 2022
Closed
@kostmo kostmo force-pushed the view-and-controller-splits branch from b38e88a to 9628667 Compare December 8, 2022 19:16
byorgey
byorgey approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not Controller.Utils and View.Utils? I'm not sure what the benefit is of repeating words as in Controller.ControllerUtils.

src/Swarm/TUI/Controller/ControllerUtils.hs Outdated Show resolved Hide resolved
@kostmo kostmo force-pushed the view-and-controller-splits branch from 9628667 to b96e266 Compare December 12, 2022 00:46
@kostmo kostmo added merge me Trigger the merge process of the Pull request. and removed merge me Trigger the merge process of the Pull request. labels Dec 12, 2022
@kostmo kostmo force-pushed the view-and-controller-splits branch from b96e266 to c5c63d4 Compare December 12, 2022 00:51
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Dec 12, 2022
@mergify mergify bot merged commit 4e8c098 into main Dec 12, 2022
@mergify mergify bot deleted the view-and-controller-splits branch December 12, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey