Extend logs for warnings #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsebek
commented
Jan 8, 2023
| @@ -109,8 +109,8 @@ handleEvent = \case | |||
| AppEvent (UpstreamVersion ev) -> do | |||
| let logReleaseEvent l e = runtimeState . eventLog %= logEvent l ("Release", -7) (T.pack $ show e) | |||
| case ev of | |||
| Left e@(FailedReleaseQuery _e) -> logReleaseEvent ErrorTrace e | |||
| Left e -> logReleaseEvent Said e | |||
byorgey
approved these changes
Jan 8, 2023
| -- ^ The ID of the robot that generated the entry. | ||
| , _leLocation :: Location | ||
| -- ^ Location of the robot at log entry creation. | ||
| , _leText :: Text |
There was a problem hiding this comment.
At #959 (comment) we discussed maybe storing something more structured here than just a Text, which I think is worth exploring. But we should probably leave that to a different PR.
There was a problem hiding this comment.
I would like to split a separate type for system logs which should also use structured errors.
I think that will make the design clear, now it's all tangled and adding anything to it would be a mistake IMO.
* split logs into separate module * make some logs warnings and fatal (to be continued...) * prepare failure logging infrastructure for TUI
Co-authored-by: Brent Yorgey <byorgey@gmail.com>
kostmo
reviewed
Jan 9, 2023
|
|
||
| -- | An entry in a robot's log. | ||
| data LogEntry = LogEntry | ||
| { _leTime :: Integer |
Closed
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
closes #1115 This PR makes use of the rich types defined in #982 and converts many functions of `Has (Throw Text)` type to `ExceptT`. It also logs a warning instead of crashing with terminal failure if "save" info cannot be loaded, which will be important for #974 where the save file schema changes. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged before #954 so it is not squashed.