Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimodal #589

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Multimodal #589

merged 1 commit into from
Oct 5, 2024

Conversation

ishaan1234
Copy link
Contributor

No description provided.

@ishaan1234 ishaan1234 requested a review from cobycloud as a code owner October 1, 2024 03:16
@cobycloud cobycloud changed the base branch from master to dev October 1, 2024 03:45
MichaelDecent
MichaelDecent reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@MichaelDecent MichaelDecent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method _format_messages is no longer an instance method (self is removed)

@3rd-Son
Copy link
Contributor

3rd-Son commented Oct 1, 2024

The method _format_messages is no longer an instance method (self is removed)

Noticed that too, this causes a conflict when calling it as self._format_messages(), where Python automatically passes self as the first argument.

To resolve this, I just added the self to the _format_messages
The tests will pass

@cobycloud cobycloud merged commit 2a6d773 into swarmauri:dev Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDecent MichaelDecent MichaelDecent left review comments

@cobycloud cobycloud Awaiting requested review from cobycloud

Assignees
No one assigned
Labels
None yet
Projects
SDK Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishaan1234 @3rd-Son @MichaelDecent @cobycloud