Comm #907
Comm #907
Conversation
There was a problem hiding this comment.
Thank you
Didn't even know when I made this mistake
|
@cobycloud please review my PR |
| def multicast(self, sender: str, recipients: List[str], message: Any) -> None: | ||
| raise NotImplementedError("Subclasses must implement multicast method") | ||
|
|
||
| def subscribe(self, topic: str, subscriber: str) -> None: |
There was a problem hiding this comment.
what if we had an HTTPTransport base that has no inherent publish and subscribe methods?
There was a problem hiding this comment.
If a transport is going to offer its own external methods for subscribe and publish, then it's likely doing so via a mixin.
As such, that would require a swarmauri_core/transport/IPubSub and a swarmauri/transport/base/PubSubMixin class.
then at the concrete-level, if a transport is going to implement the IPubSub interface, it can do so via PubSubMixin,
There was a problem hiding this comment.
ohh, now I see
Great, I understand this
| from typing import Any, List | ||
|
|
||
|
|
||
| class ITransportComm(ABC): |
There was a problem hiding this comment.
we'll drop the comm part and only refer to as Transport
| import datetime | ||
| from swarmauri_core.transport.ITransport import ITransport | ||
|
|
||
| class TransportationProtocol(Enum): |
There was a problem hiding this comment.
this might come in handy
There was a problem hiding this comment.
include test methods to test:
- resource kind
- type
- serialization
| Returns: | ||
| str: Unique subscriber ID | ||
| """ | ||
| subscriber_id = str(uuid4()) |
There was a problem hiding this comment.
TransportBase inherits ComponentBase. All subclasses of ComponentBase automatically have an internal id accessible at
self.id
There was a problem hiding this comment.
Thank you @cobycloud
@cobycloud
I have implemented the
base classandcore abstractclass fortransportPlease give it a look and let me know if I should proceed with
concrete implementationsandtest cases