Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move fork-ts-checker-webpack-plugin from direct dependency #29

Closed
swashata opened this issue Oct 29, 2018 · 0 comments
Closed

move fork-ts-checker-webpack-plugin from direct dependency #29

swashata opened this issue Oct 29, 2018 · 0 comments
Labels
good first issue Good for newcomers Priority: Medium Status: Available awaiting release Type: Refactoring

Comments

@swashata
Copy link
Owner

This one has a peerDep of typescript. We can completely remove it since we are requiring it at runtime anyway.

Also update the docs to reflect the change. If user needs support for typescript, then npm i -D fork-ts-checker-webpack-plugin is required.
swashata added a commit that referenced this issue Oct 30, 2018
@swashata
feat: remove fork-ts-checker-webpack-plugin from dependency
b1d3c07 
Add it to the docs, so that packages that require typescript are
able to add to their dependency.

See #29
@swashata swashata added Status: Available awaiting release and removed Status: Proposal labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Priority: Medium Status: Available awaiting release Type: Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swashata