Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of wrapping C pointers in Go structs, wrap C values in Go
structs, then convert C pointers to Go pointers. This lets us use
actual pointers in the API, simplifying things like nil pointer
checks.
We use the notinheap hint for some added safety around C pointer
rules (i.e. users can't accidentally allocate their own wrappers on
the Go heap and pass them to C) and for some added performance (as the
compiler can avoid generating barriers and whatnot when accessing
these pointers.)
Note that this still won't let us set finalizers, as the pointers
aren't managed by Go and thus don't get garbage collected.