Keep CAP_SYS_PTRACE with suid binary #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
reviewed
Jan 12, 2017
| if (suid) { | ||
| // Drop every cap except CAP_SYS_PTRACE | ||
| cap_t caps = cap_init(); | ||
| cap_value_t keep = CAP_SYS_PTRACE; |
There was a problem hiding this comment.
Don't we also want that TTY one?
There was a problem hiding this comment.
No, it was required because a suid binary would not gain all caps as effective, and besides, all the privileged stuff is dealt with in a child process of wlc (forked in wlc_init, so it keeps everything), so it isn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes sway when run with suid binary. (suid does not work with filecaps in an intuitive manner, so breakage occurs).
Note: suid binary will not require CAP_SYS_PTRACE.