Fix redundant call to seat_send_focus() #5130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix calling to seat_send_focus() twice when a view is closed. This codes revert swaywm#2580, but the original issue nolonger exists.
ddevault
approved these changes
Mar 23, 2020
|
Is there a related ticket that describes a problem this fixes? |
|
I found this problem during debugging #4740 |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes calling to
seat_send_focus()twice when a view is closed.This PR basically revert #2580.
I have tested that the original issue no longer exists. Closing a fullscreen view can successful focus to another view even after reverting.