Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: subproject support for wayland-protocols #6497

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Sep 8, 2021

As in wlroots: swaywm/wlroots#2953.

To build sway on my system with outdated wayland-protocols (1.20):

  • add wlroots, wayland-protocols, seatd as subprojects
  • run meson setup --force-fallback-for wayland-protocols build
  • ...

Without the force-fallback, sway finds wayland-protocols from the system, which does not satisfy wlroots (>=1.21) and the setup fails without a good error message.

I'll add a note in the wiki if this is merged.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since Meson 0.58.0 we can use this syntax, and we already require 0.58.1.

(since 0.58.0) added varname as first positional argument. It is used as default value for cmake, pkgconfig, configtool and internal keyword arguments.

@emersion emersion merged commit adf9e16 into swaywm:master Sep 8, 2021
@emersion
Copy link
Member

emersion commented Sep 8, 2021

Thanks!

@lbonn lbonn deleted the wayland-protos-subproject branch September 8, 2021 08:29
@lbonn
Copy link
Contributor Author

lbonn commented Sep 8, 2021

About the second problem, I realized that there is no point to not require the same version of wayland-protocols that wlroots needs, so I opened #6498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants