-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pcre with pcre2 #6883
Replace pcre with pcre2 #6883
Conversation
I'm not too sure how to fix the build since pcre was not listed in any of the .yml build files. Any suggestions? |
I guess the dependency wasn't explicit because base system packages depend on pcre v1, so we got it "by chance". We need to make the pcre v2 dep explicit in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good to me!
The package seems to have a different name on alpine. Maybe drop the suffix after the 2?
|
Thank you, now it's building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you @psychon for fixing the patch I've sent over email. This should fix #6838.