-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dpms output command to power #7083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the small nit, thanks!
The "dpms" command refers to VESA Display Power Management Signaling, a deprecated standard. It's superseded by VESA DPM. Instead of tying out command name to a particular standard, use the neutral term "power".
269a7c3
to
de5bf4d
Compare
Release notes: - Sway: https://github.com/swaywm/sway/releases/tag/1.8 - wlroots: https://gitlab.freedesktop.org/wlroots/wlroots/-/releases/0.16.0 Known user-facing breaking changes: - Manufacturer names in output identifiers might have changed: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3541#note_1384124 - The output dpms command has been deprecated (superseded by output power): swaywm/sway#7083
@@ -119,12 +119,20 @@ must be separated by one space. For example: | |||
Enables or disables the specified output (all outputs are enabled by | |||
default). | |||
|
|||
As opposed to the _power_ command, the output will loose its current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/loose/lose/
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
The "dpms" command refers to VESA Display Power Management
Signaling, a deprecated standard. It's superseded by VESA DPM.
Instead of tying out command name to a particular standard, use the
neutral term "power".