This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
layer_shell: set layer of existing surface #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Oct 9, 2019
| @@ -236,6 +236,13 @@ | |||
| </description> | |||
| </request> | |||
|
|
|||
| <request name="set_layer" since="2"> | |||
| <description summary="change the layer of the surface"> | |||
| Change the layer that the surface is rendered on. | |||
There was a problem hiding this comment.
This should specify that this is double-buffered, see the other requests.
I'd also be more comfortable with appending this at the end of the interface, with a <!-- Version 2 additions --> comment.
There was a problem hiding this comment.
Done, also updated these lines to include layer as something that is double buffered.
Timidger
force-pushed
the
layer-shell-set-layer
branch
from
60609da
to
7495a8b
Compare
ddevault
approved these changes
Oct 16, 2019
|
LGTM, @emersion? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.