Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

External renderer #3195

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

bl4ckb0ne
Copy link
Contributor

Allows for user to plug their renderer instead of creating one under the hood.

@emersion
Copy link
Member

"render/egl: make most functions public" -- hmm, I don't know if we want to go down this path and build a custom renderer framework library. Do you have example code using it?

"types/buffer: make {begin,end}_data_ptr_access part of the public API" -- ACK

"render/pixel_format: make wlr_pixel_format_info part of the public API" -- what is this used for? Example downstream code maybe?

"render: wlr_renderer_init_wl_display fails if no renderer is provided" -- I think I'd rather just let it crash like it is today...

This is missing the main ingredient: stop initializing the renderer and allocator in the backend init functions.

@bl4ckb0ne
Copy link
Contributor Author

bl4ckb0ne commented Sep 13, 2021

https://git.sr.ht/~bl4ckb0ne/wxrc/commit/4d4f63055d68c696520fa0dcc6004450f5fd53d3 very WIP, wlr_egl saves me a bunch of code. But it would be totally doable on my own.

Pixel format info is required downstream for texture handling, but might be optional.

@emersion
Copy link
Member

"types/buffer: make {begin,end}_data_ptr_access part of the public API" -- pushed to master

I think the rest is still very much WIP.

@emersion
Copy link
Member

emersion commented Nov 1, 2021

wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3195

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants