Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

xdg-shell: drop wlr_xdg_toplevel_set_fullscreen_event #3229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vyivel
Copy link
Member

@vyivel vyivel commented Oct 1, 2021

Instead, compositors can read relevant values from wlr_xdg_toplevel.requested.


This is a breaking change: wlr_xdg_toplevel.events.set_fullscreen listeners now receive a wlr_xdg_surface and are supposed to read wlr_xdg_toplevel.requested.fullscreen{,_output}.

@emersion
Copy link
Member

emersion commented Oct 1, 2021

Not sure we want this.

Kirill Primak added 2 commits October 1, 2021 16:43
The requested properties can be read by compositors on any relevant
event (set_maximized, set_fullscreen etc), not just surface map.
Reading `minimized` only makes sense on surface map, as the compositor
can't handle set_minimized events before that.
Instead, compositors can read relevant values from
wlr_xdg_toplevel.requested.
@vyivel vyivel force-pushed the xdg-toplevel-nuke-fullscreen-event branch from 97c9b2e to 7832482 Compare October 1, 2021 13:45
@vyivel
Copy link
Member Author

vyivel commented Oct 1, 2021

Why not? (un)set_maximized and wlr_xdg_toplevel_decoration_v1.events.request_mode follow the same logic.

@vyivel vyivel marked this pull request as ready for review October 1, 2021 13:48
@vyivel vyivel added breaking Breaking change in public API xdg-shell labels Oct 1, 2021
};

wlr_signal_emit_safe(&surface->toplevel->events.request_fullscreen, &event);
wlr_signal_emit_safe(&surface->toplevel->events.request_fullscreen, surface);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to avoid introducing more cases where we use surface as the signal data pointer, for the reasons described in #1008 (comment).

@emersion
Copy link
Member

emersion commented Oct 7, 2021

It's one of these cases where I'm not sure the breaking changes are worth the effort. Much like @ifreund's "borderline bikeshedding" patch series.

I'm not feeling strongly about this.

@emersion
Copy link
Member

emersion commented Nov 1, 2021

wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3229

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API xdg-shell
Development

Successfully merging this pull request may close these issues.

2 participants