Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Remove get_presentation_clock from wlr_backend interface #3254

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bl4ckb0ne
Copy link
Contributor

DRM_CAP_TIMESTAMP_MONOTONIC has been supported since kernel version 2.6.39, there's very little need to query the backend clock every time. We can safely assume CLOCK_MONOTONIC.

@bl4ckb0ne bl4ckb0ne added the breaking Breaking change in public API label Oct 13, 2021
@bl4ckb0ne bl4ckb0ne force-pushed the nuke_backend_get_presentation_clock branch from ccc23e4 to a851ff8 Compare October 13, 2021 20:43
@bl4ckb0ne bl4ckb0ne force-pushed the nuke_backend_get_presentation_clock branch from a851ff8 to 9463c86 Compare October 13, 2021 20:52
vyivel
vyivel previously approved these changes Oct 15, 2021
Copy link
Member

@vyivel vyivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs a rebase, though.

@bl4ckb0ne bl4ckb0ne force-pushed the nuke_backend_get_presentation_clock branch from 9463c86 to 8d18e2b Compare October 15, 2021 13:51
@emersion
Copy link
Member

There's one thing though: the Wayland backend assumes CLOCK_MONOTONIC because it ignores the clock_id event. This is incorrect.

@emersion emersion dismissed vyivel’s stale review October 20, 2021 14:19

Need fix for comment above

@emersion
Copy link
Member

emersion commented Nov 1, 2021

wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3254

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend/drm backend breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

3 participants