fix(emotion): Strip backslashed segments for Windows path #328
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
@swc/plugin-emotion
is used on Windows, it produces invalid CSS class names. Apparently this is an unsolved issue for Rust. In this PR I've updated the calculation of the[filename]
labelFormat
such that it handles both the Windows path, which includes the full path to the file, including backslashes, and the Unix path (which was working fine to begin with).I have set up a minimal repo for reproducing the issue and verifying the fix. The issue can be reproduced on the
main
branch, and the fix can be verified on thefix
branch. Thefix
branch replaces the compiledswc_plugin_emotion.wasm
from@swc/plugin-emotion
npm package with one I built myself via my fork of this repo.Before
After
Fixes #327