Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(register): return addHook result to it can be reverted #647

Merged
merged 1 commit into from
Mar 31, 2022
Merged

feat(register): return addHook result to it can be reverted #647

merged 1 commit into from
Mar 31, 2022

Commits on Mar 30, 2022

  1. feat(register): return addHook result to it can be reverted 

    Currently the `register` method doesn't return the result of `pirates#addHook`, which means you can't revert the registration of the hook. This is very useful in circumstances like `jest-config`, which temporarily registers the transform, reads the config file, then de-registers it. See below

https://github.com/facebook/jest/blob/199f9811ae68b15879cbe18b7ef7ebd61eefcf23/packages/jest-config/src/readConfigFileAndSetRootDir.ts#L83-101
    @Craga89
    Craga89 authored Mar 30, 2022
    Configuration menu
    Copy the full SHA
    222e205 View commit details
    Browse the repository at this point in the history