fix(es/minifier): Handle cyclic references while dropping unused prop…

…erties (#8725)

**Related issue:**

 - Closes #8714

crates/swc/tests/fixture/issues-8xxx/8714/input/.swcrc

@@ -0,0 +1,65 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "ecmascript",
+            "jsx": false
+        },
+        "target": "es2022",
+        "loose": false,
+        "minify": {
+            "compress": {
+                "arguments": false,
+                "arrows": true,
+                "booleans": true,
+                "booleans_as_integers": false,
+                "collapse_vars": true,
+                "comparisons": true,
+                "computed_props": true,
+                "conditionals": true,
+                "dead_code": true,
+                "directives": true,
+                "drop_console": false,
+                "drop_debugger": true,
+                "evaluate": true,
+                "expression": false,
+                "hoist_funs": false,
+                "hoist_props": true,
+                "hoist_vars": false,
+                "if_return": true,
+                "join_vars": true,
+                "keep_classnames": false,
+                "keep_fargs": true,
+                "keep_fnames": false,
+                "keep_infinity": false,
+                "loops": true,
+                "negate_iife": true,
+                "properties": true,
+                "reduce_funcs": false,
+                "reduce_vars": false,
+                "side_effects": true,
+                "switches": true,
+                "typeofs": true,
+                "unsafe": false,
+                "unsafe_arrows": false,
+                "unsafe_comps": false,
+                "unsafe_Function": false,
+                "unsafe_math": false,
+                "unsafe_symbols": false,
+                "unsafe_methods": false,
+                "unsafe_proto": false,
+                "unsafe_regexp": false,
+                "unsafe_undefined": false,
+                "unused": false,
+                "const_to_let": true,
+                "pristine_globals": true,
+                "passes": 3
+            },
+            "mangle": false
+        }
+    },
+    "module": {
+        "type": "es6"
+    },
+    "minify": false,
+    "isModule": true
+}

crates/swc/tests/fixture/issues-8xxx/8714/input/1.js

@@ -0,0 +1,5 @@
+const foo = {
+    x: 1,
+    y: () => foo
+};
+console.log(foo.y().x); // should log: 1

crates/swc/tests/fixture/issues-8xxx/8714/output/1.js

@@ -0,0 +1,5 @@
+const foo = {
+    x: 1,
+    y: ()=>foo
+};
+console.log(foo.y().x);

crates/swc_ecma_minifier/src/compress/optimize/unused.rs

@@ -793,7 +793,7 @@ impl Optimizer<'_> {
 
         let usage = self.data.vars.get(&name.to_id())?;
 
-        if usage.indexed_with_dynamic_key || usage.used_as_ref {
+        if usage.indexed_with_dynamic_key || usage.used_as_ref || usage.used_recursively {
             return None;
         }
 

crates/swc_ecma_minifier/tests/fixture/issues/8714/config.json

@@ -0,0 +1,3 @@
+{
+    "defaults": true
+}

crates/swc_ecma_minifier/tests/fixture/issues/8714/input.js

@@ -0,0 +1,5 @@
+const foo = {
+    x: 1,
+    y: () => foo
+};
+console.log(foo.y().x); 

crates/swc_ecma_minifier/tests/fixture/issues/8714/output.js

@@ -0,0 +1,5 @@
+const foo = {
+    x: 1,
+    y: ()=>foo
+};
+console.log(foo.y().x);