-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(es): Change error message as it can be misleading (#3982)
- Loading branch information
Showing
3 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48f2fd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
base_tr_fixer
26983
ns/iter (± 986
)23665
ns/iter (± 578
)1.14
base_tr_resolver_and_hygiene
152215
ns/iter (± 27810
)128808
ns/iter (± 19923
)1.18
codegen_es2015
33056
ns/iter (± 432
)27521
ns/iter (± 183
)1.20
codegen_es2016
33060
ns/iter (± 227
)27388
ns/iter (± 256
)1.21
codegen_es2017
33133
ns/iter (± 297
)27487
ns/iter (± 543
)1.21
codegen_es2018
33206
ns/iter (± 479
)27549
ns/iter (± 211
)1.21
codegen_es2019
33163
ns/iter (± 320
)27448
ns/iter (± 257
)1.21
codegen_es2020
33430
ns/iter (± 308
)27554
ns/iter (± 342
)1.21
codegen_es3
33036
ns/iter (± 501
)27499
ns/iter (± 192
)1.20
codegen_es5
33176
ns/iter (± 989
)27472
ns/iter (± 211
)1.21
full_es2015
169219831
ns/iter (± 15624262
)139513847
ns/iter (± 4440078
)1.21
full_es2016
167632085
ns/iter (± 8316579
)137626020
ns/iter (± 23086229
)1.22
full_es2017
167556189
ns/iter (± 9316406
)137370664
ns/iter (± 25384570
)1.22
full_es2018
165701242
ns/iter (± 11560472
)135850570
ns/iter (± 24429513
)1.22
full_es2019
165619059
ns/iter (± 12145638
)135498085
ns/iter (± 24819108
)1.22
full_es2020
158969848
ns/iter (± 10659510
)125541855
ns/iter (± 20756760
)1.27
full_es3
226875639
ns/iter (± 11333093
)184167665
ns/iter (± 22631533
)1.23
full_es5
214012568
ns/iter (± 18792593
)174918232
ns/iter (± 23330527
)1.22
parser
682642
ns/iter (± 14168
)553565
ns/iter (± 19152
)1.23
ser_ast_node
185
ns/iter (± 3
)148
ns/iter (± 2
)1.25
ser_serde
188
ns/iter (± 4
)151
ns/iter (± 2
)1.25
emit_colors
13245295
ns/iter (± 8985966
)4949527
ns/iter (± 3456160
)2.68
emit_large
128924876
ns/iter (± 206867744
)124445851
ns/iter (± 185969138
)1.04
base_clone
2726824
ns/iter (± 321657
)2643660
ns/iter (± 68731
)1.03
fold_span
4828155
ns/iter (± 911200
)4467815
ns/iter (± 150652
)1.08
fold_span_panic
5176950
ns/iter (± 760540
)4685691
ns/iter (± 120084
)1.10
visit_mut_span
3363850
ns/iter (± 327400
)3210272
ns/iter (± 217367
)1.05
visit_mut_span_panic
3437921
ns/iter (± 457092
)3073045
ns/iter (± 79718
)1.12
usage_builtin_type
18699816
ns/iter (± 11595138
)15374347
ns/iter (± 9609023
)1.22
usage_property
440858
ns/iter (± 4481
)356196
ns/iter (± 2405
)1.24
boxing_boxed
211
ns/iter (± 1
)168
ns/iter (± 0
)1.26
boxing_boxed_clone
115
ns/iter (± 0
)92
ns/iter (± 0
)1.25
boxing_unboxed
145
ns/iter (± 0
)120
ns/iter (± 0
)1.21
boxing_unboxed_clone
79
ns/iter (± 0
)63
ns/iter (± 0
)1.25
time_10
409
ns/iter (± 11
)300
ns/iter (± 4
)1.36
time_15
849
ns/iter (± 40
)662
ns/iter (± 2
)1.28
time_20
1417
ns/iter (± 18
)1432
ns/iter (± 9
)0.99
time_40
5127
ns/iter (± 42
)7002
ns/iter (± 24
)0.73
time_5
123
ns/iter (± 2
)99
ns/iter (± 2
)1.24
time_60
10750
ns/iter (± 55
)16656
ns/iter (± 56
)0.65
total
0
ns/iter (± 0
)0
ns/iter (± 0
)NaN
This comment was automatically generated by workflow using github-action-benchmark.
48f2fd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.emit_colors
13245295
ns/iter (± 8985966
)4949527
ns/iter (± 3456160
)2.68
This comment was automatically generated by workflow using github-action-benchmark.
CC: @kdy1