fix(es/minifier): Don't create top level variables (#2985)

swc_ecma_minifier: - Add `module` to `TerserCompressorOptions`. - Don't create top level variables while inlining if `module` is false. - Drop more unused parameters.
swc-project · Dec 7, 2021 · 4a7937d · 4a7937d · github-actions · Dec 7, 2021
1 parent 20179a6
commit 4a7937d
Show file tree

Hide file tree

Showing 18 changed files with 116 additions and 66 deletions.
diff --git a/...essions/classWithStaticFieldInParameterBindingPattern.2/input.ts/es5.2.minified/output.js b/...essions/classWithStaticFieldInParameterBindingPattern.2/input.ts/es5.2.minified/output.js
@@ -49,7 +49,7 @@ var _class, _class1, C = function() {
     "use strict";
     _classCallCheck(this, C);
 };
-!function(param) {
+!function() {
     (void 0)[((_class = (function(C) {
         "use strict";
         _inherits(_class, C);
@@ -59,7 +59,7 @@ var _class, _class1, C = function() {
         }
         return _class;
     })(C)).x = 1, _class).x];
-}(), (function(param) {
+}(), (function() {
     (void 0)[((_class1 = (function(C) {
         "use strict";
         _inherits(_class, C);

diff --git a/...essions/classWithStaticFieldInParameterBindingPattern.3/input.ts/es5.2.minified/output.js b/...essions/classWithStaticFieldInParameterBindingPattern.3/input.ts/es5.2.minified/output.js
@@ -49,7 +49,7 @@ var _class, _class1, C = function() {
     "use strict";
     _classCallCheck(this, C);
 };
-!function(param) {
+!function() {
     (void 0)[((_class = (function(C) {
         "use strict";
         _inherits(_class, C);
@@ -59,7 +59,7 @@ var _class, _class1, C = function() {
         }
         return _class;
     })(C)).x = 1, _class).x];
-}(), (function(param) {
+}(), (function() {
     (void 0)[((_class1 = (function(C) {
         "use strict";
         _inherits(_class, C);

diff --git a/...nalChaining/optionalChainingInParameterBindingPattern.2/input.ts/es5.2.minified/output.js b/...nalChaining/optionalChainingInParameterBindingPattern.2/input.ts/es5.2.minified/output.js
@@ -1,5 +1,5 @@
 var ref, ref1, a = function() {
 };
-(void 0)[null === (ref = a()) || void 0 === ref ? void 0 : ref.d], (function(param) {
+(void 0)[null === (ref = a()) || void 0 === ref ? void 0 : ref.d], (function() {
     (void 0)[null === (ref1 = a()) || void 0 === ref1 ? void 0 : ref1.d], arguments.length > 1 && void 0 !== arguments[1] && arguments[1];
 })();
diff --git a/crates/swc/tests/tsc.rs b/crates/swc/tests/tsc.rs
@@ -76,8 +76,8 @@ fn matrix() -> Vec<(String, Options)> {
                         target: Some(target),
                         minify: if minify {
                             Some(from_json(
-                                "{ \"compress\": { \"toplevel\": true }, \"mangle\": false, \
-                                 \"toplevel\": true }",
+                                "{ \"compress\": { \"toplevel\": true, \"module\": true }, \
+                                 \"mangle\": false, \"toplevel\": true }",
                             ))
                         } else {
                             None

diff --git a/crates/swc/tests/vercel/full-compact/d3-color/1/output/index.js b/crates/swc/tests/vercel/full-compact/d3-color/1/output/index.js
diff --git a/crates/swc/tests/vercel/full-compact/react-autosuggest/1/output/index.js b/crates/swc/tests/vercel/full-compact/react-autosuggest/1/output/index.js
Benchmark suite	Current: `4a7937d`	Previous: `20179a6`	Ratio
`full_es2015`	`178802365` ns/iter (`± 23829187`)	`199088704` ns/iter (`± 9180703`)	`0.90`
`full_es2016`	`130265879` ns/iter (`± 5906385`)	`160859778` ns/iter (`± 9304873`)	`0.81`
`full_es2017`	`134607173` ns/iter (`± 6333929`)	`163965339` ns/iter (`± 9148249`)	`0.82`
`full_es2018`	`133966569` ns/iter (`± 18862215`)	`161658185` ns/iter (`± 7509668`)	`0.83`
`full_es2019`	`144900840` ns/iter (`± 15480644`)	`160893500` ns/iter (`± 6929672`)	`0.90`
`full_es2020`	`132830156` ns/iter (`± 5530700`)	`158717903` ns/iter (`± 7813790`)	`0.84`
`full_es3`	`187275288` ns/iter (`± 368016048`)	`224986255` ns/iter (`± 18253156`)	`0.83`
`full_es5`	`174605896` ns/iter (`± 20435477`)	`209176289` ns/iter (`± 11881676`)	`0.83`
`parser`	`615596` ns/iter (`± 26625`)	`744947` ns/iter (`± 66199`)	`0.83`