Skip to content

Commit

Permalink
chore: Revert #2907
Browse files Browse the repository at this point in the history
  • Loading branch information
@kdy1
kdy1 committed Nov 29, 2021
1 parent 166c12d commit 666e3cc
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 51 deletions.
49 changes: 2 additions & 47 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/swc_ecma_preset_env/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ version = "0.67.3"
[dependencies]
ahash = "0.7.4"
anyhow = "1"
browserslist-rs = "=0.3.2"
browserslist-rs = "=0.2.0"
dashmap = "4.0.2"
indexmap = "1.6.2"
once_cell = "1.2.0"
Expand Down
7 changes: 4 additions & 3 deletions crates/swc_ecma_preset_env/src/lib.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -592,9 +592,10 @@ impl Query {
{
let distribs = browserslist::resolve(
s,
browserslist::Opts::new()
.mobile_to_desktop(true)
.ignore_unknown_versions(true),
&browserslist::Opts {
mobile_to_desktop: true,
ignore_unknown_versions: true,
},
)
.with_context(|| {
format!(
Expand Down

2 comments on commit 666e3cc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 666e3cc Previous: 166c12d Ratio
base_tr_fixer 31325 ns/iter (± 4106) 25270 ns/iter (± 1807) 1.24
base_tr_resolver_and_hygiene 180522 ns/iter (± 41016) 152157 ns/iter (± 14579) 1.19
codegen_es2015 65078 ns/iter (± 7092) 56892 ns/iter (± 3253) 1.14
codegen_es2016 63761 ns/iter (± 8181) 57439 ns/iter (± 3596) 1.11
codegen_es2017 64028 ns/iter (± 6694) 60079 ns/iter (± 3591) 1.07
codegen_es2018 64443 ns/iter (± 9927) 58086 ns/iter (± 3266) 1.11
codegen_es2019 63826 ns/iter (± 6242) 59740 ns/iter (± 4820) 1.07
codegen_es2020 64857 ns/iter (± 10291) 58213 ns/iter (± 6278) 1.11
codegen_es3 64453 ns/iter (± 13280) 58130 ns/iter (± 3246) 1.11
codegen_es5 64962 ns/iter (± 7817) 57354 ns/iter (± 2234) 1.13
full_es2015 212028746 ns/iter (± 9358828) 209338792 ns/iter (± 10559891) 1.01
full_es2016 168313059 ns/iter (± 12385532) 163851471 ns/iter (± 7047116) 1.03
full_es2017 175352377 ns/iter (± 11790716) 176685720 ns/iter (± 13076815) 0.99
full_es2018 169983906 ns/iter (± 16335626) 172880459 ns/iter (± 8600433) 0.98
full_es2019 158731475 ns/iter (± 20242562) 172425150 ns/iter (± 7999165) 0.92
full_es2020 157208326 ns/iter (± 17221826) 170916345 ns/iter (± 7134560) 0.92
full_es3 224139044 ns/iter (± 28320368) 245193441 ns/iter (± 12405287) 0.91
full_es5 209961240 ns/iter (± 23316684) 223590348 ns/iter (± 9624537) 0.94
parser 745818 ns/iter (± 98345) 788409 ns/iter (± 61745) 0.95
ser_ast_node 160 ns/iter (± 31) 175 ns/iter (± 10) 0.91
ser_serde 157 ns/iter (± 21) 180 ns/iter (± 5) 0.87
emit_colors 18151180 ns/iter (± 26025531) 19517019 ns/iter (± 24631542) 0.93
emit_large 86461738 ns/iter (± 136926284) 132261258 ns/iter (± 191112727) 0.65
base_clone 2464035 ns/iter (± 283147) 2806361 ns/iter (± 177478) 0.88
fold_span 4119650 ns/iter (± 1093122) 4600109 ns/iter (± 329861) 0.90
fold_span_panic 4303795 ns/iter (± 445691) 4733514 ns/iter (± 317686) 0.91
visit_mut_span 2945322 ns/iter (± 365077) 3365499 ns/iter (± 184726) 0.88
visit_mut_span_panic 3035700 ns/iter (± 506933) 3449370 ns/iter (± 256592) 0.88
ast_clone 20279 ns/iter (± 3807) 19676 ns/iter (± 1036) 1.03
ast_clone_to_stable 68307 ns/iter (± 8098) 56169 ns/iter (± 3162) 1.22
ast_clone_to_stable_then_to_unstable 120449 ns/iter (± 13472) 106076 ns/iter (± 10421) 1.14
json_deserialize 2206960 ns/iter (± 190636) 2225789 ns/iter (± 143326) 0.99
json_serialize 96585 ns/iter (± 29096) 105764 ns/iter (± 5730) 0.91
boxing_boxed 130 ns/iter (± 37) 149 ns/iter (± 9) 0.87
boxing_boxed_clone 69 ns/iter (± 9) 79 ns/iter (± 3) 0.87
boxing_unboxed 138 ns/iter (± 13) 126 ns/iter (± 8) 1.10
boxing_unboxed_clone 85 ns/iter (± 9) 72 ns/iter (± 4) 1.18
time_10 343 ns/iter (± 26) 401 ns/iter (± 25) 0.86
time_15 719 ns/iter (± 108) 772 ns/iter (± 37) 0.93
time_20 1313 ns/iter (± 106) 1327 ns/iter (± 77) 0.99
time_40 4969 ns/iter (± 473) 4598 ns/iter (± 337) 1.08
time_5 110 ns/iter (± 14) 117 ns/iter (± 9) 0.94
time_60 10508 ns/iter (± 1123) 10015 ns/iter (± 690) 1.05

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 666e3cc Previous: 166c12d Ratio
base_tr_fixer 32334 ns/iter (± 6901) 25270 ns/iter (± 1807) 1.28
base_tr_resolver_and_hygiene 182494 ns/iter (± 70797) 152157 ns/iter (± 14579) 1.20
codegen_es2015 69120 ns/iter (± 17835) 56892 ns/iter (± 3253) 1.21
codegen_es2016 68960 ns/iter (± 16537) 57439 ns/iter (± 3596) 1.20
codegen_es2017 68770 ns/iter (± 10152) 60079 ns/iter (± 3591) 1.14
codegen_es2018 70048 ns/iter (± 16380) 58086 ns/iter (± 3266) 1.21
codegen_es2019 66689 ns/iter (± 10911) 59740 ns/iter (± 4820) 1.12
codegen_es2020 68647 ns/iter (± 9486) 58213 ns/iter (± 6278) 1.18
codegen_es3 68224 ns/iter (± 10266) 58130 ns/iter (± 3246) 1.17
codegen_es5 70425 ns/iter (± 10624) 57354 ns/iter (± 2234) 1.23
full_es2015 222201205 ns/iter (± 16866377) 209338792 ns/iter (± 10559891) 1.06
full_es2016 173198799 ns/iter (± 11040224) 163851471 ns/iter (± 7047116) 1.06
full_es2017 182415273 ns/iter (± 17892689) 176685720 ns/iter (± 13076815) 1.03
full_es2018 183494320 ns/iter (± 20643315) 172880459 ns/iter (± 8600433) 1.06
full_es2019 178347762 ns/iter (± 18679278) 172425150 ns/iter (± 7999165) 1.03
full_es2020 177492771 ns/iter (± 16649710) 170916345 ns/iter (± 7134560) 1.04
full_es3 256580970 ns/iter (± 26537484) 245193441 ns/iter (± 12405287) 1.05
full_es5 231366198 ns/iter (± 21798426) 223590348 ns/iter (± 9624537) 1.03
parser 858872 ns/iter (± 152270) 788409 ns/iter (± 61745) 1.09
ser_ast_node 181 ns/iter (± 26) 175 ns/iter (± 10) 1.03
ser_serde 180 ns/iter (± 26) 180 ns/iter (± 5) 1
emit_colors 10059575 ns/iter (± 6548722) 19517019 ns/iter (± 24631542) 0.52
emit_large 80206850 ns/iter (± 103491801) 132261258 ns/iter (± 191112727) 0.61
base_clone 3002030 ns/iter (± 436560) 2806361 ns/iter (± 177478) 1.07
fold_span 4852944 ns/iter (± 626835) 4600109 ns/iter (± 329861) 1.05
fold_span_panic 5243594 ns/iter (± 770145) 4733514 ns/iter (± 317686) 1.11
visit_mut_span 3386617 ns/iter (± 379803) 3365499 ns/iter (± 184726) 1.01
visit_mut_span_panic 3552238 ns/iter (± 427318) 3449370 ns/iter (± 256592) 1.03
ast_clone 25397 ns/iter (± 3184) 19676 ns/iter (± 1036) 1.29
ast_clone_to_stable 79519 ns/iter (± 8956) 56169 ns/iter (± 3162) 1.42
ast_clone_to_stable_then_to_unstable 140051 ns/iter (± 19421) 106076 ns/iter (± 10421) 1.32
json_deserialize 2705857 ns/iter (± 385226) 2225789 ns/iter (± 143326) 1.22
json_serialize 111180 ns/iter (± 13445) 105764 ns/iter (± 5730) 1.05
boxing_boxed 183 ns/iter (± 22) 149 ns/iter (± 9) 1.23
boxing_boxed_clone 80 ns/iter (± 11) 79 ns/iter (± 3) 1.01
boxing_unboxed 164 ns/iter (± 18) 126 ns/iter (± 8) 1.30
boxing_unboxed_clone 75 ns/iter (± 6) 72 ns/iter (± 4) 1.04
time_10 376 ns/iter (± 44) 401 ns/iter (± 25) 0.94
time_15 812 ns/iter (± 156) 772 ns/iter (± 37) 1.05
time_20 1476 ns/iter (± 219) 1327 ns/iter (± 77) 1.11
time_40 5770 ns/iter (± 963) 4598 ns/iter (± 337) 1.25
time_5 124 ns/iter (± 18) 117 ns/iter (± 9) 1.06
time_60 12370 ns/iter (± 1480) 10015 ns/iter (± 690) 1.24

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.