Skip to content

Commit

Permalink
fix(node-swc): Add missing const_to_let to the type (#6615)
Browse files Browse the repository at this point in the history
  • Loading branch information
SukkaW authored Dec 11, 2022
1 parent a5efa8a commit 7e841a5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions node-swc/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ export interface TerserCompressOptions {

unused?: boolean,

const_to_let?: boolean

module?: boolean,
}
Expand Down

1 comment on commit 7e841a5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7e841a5 Previous: 2bf7805 Ratio
es/full/bugs-1 296219 ns/iter (± 10136) 296832 ns/iter (± 4023) 1.00
es/full/minify/libraries/antd 1724407440 ns/iter (± 28345724) 1716353553 ns/iter (± 16076769) 1.00
es/full/minify/libraries/d3 335252556 ns/iter (± 9701395) 327560562 ns/iter (± 8650693) 1.02
es/full/minify/libraries/echarts 1474992441 ns/iter (± 22519559) 1431134271 ns/iter (± 28156839) 1.03
es/full/minify/libraries/jquery 91404188 ns/iter (± 811966) 90184955 ns/iter (± 1145776) 1.01
es/full/minify/libraries/lodash 110302294 ns/iter (± 1634262) 108141168 ns/iter (± 1588047) 1.02
es/full/minify/libraries/moment 53356419 ns/iter (± 430747) 52542190 ns/iter (± 594651) 1.02
es/full/minify/libraries/react 19651369 ns/iter (± 202990) 19351175 ns/iter (± 196714) 1.02
es/full/minify/libraries/terser 260290471 ns/iter (± 8888729) 259205727 ns/iter (± 5424376) 1.00
es/full/minify/libraries/three 482146227 ns/iter (± 12251776) 481490161 ns/iter (± 7326624) 1.00
es/full/minify/libraries/typescript 3305402328 ns/iter (± 14333853) 3283681965 ns/iter (± 10944429) 1.01
es/full/minify/libraries/victory 715759977 ns/iter (± 24287885) 695422591 ns/iter (± 26201645) 1.03
es/full/minify/libraries/vue 135365368 ns/iter (± 2127443) 132054684 ns/iter (± 1450756) 1.03
es/full/codegen/es3 26821 ns/iter (± 138) 26964 ns/iter (± 209) 0.99
es/full/codegen/es5 26676 ns/iter (± 177) 27009 ns/iter (± 232) 0.99
es/full/codegen/es2015 26822 ns/iter (± 201) 26871 ns/iter (± 208) 1.00
es/full/codegen/es2016 26799 ns/iter (± 113) 26956 ns/iter (± 177) 0.99
es/full/codegen/es2017 26864 ns/iter (± 90) 26855 ns/iter (± 268) 1.00
es/full/codegen/es2018 26758 ns/iter (± 175) 26944 ns/iter (± 235) 0.99
es/full/codegen/es2019 26862 ns/iter (± 167) 26773 ns/iter (± 198) 1.00
es/full/codegen/es2020 26897 ns/iter (± 159) 26984 ns/iter (± 148) 1.00
es/full/all/es3 169108796 ns/iter (± 2215829) 167894922 ns/iter (± 1537450) 1.01
es/full/all/es5 160580176 ns/iter (± 1654655) 161751727 ns/iter (± 2666836) 0.99
es/full/all/es2015 120736199 ns/iter (± 1438692) 120060964 ns/iter (± 802715) 1.01
es/full/all/es2016 119552094 ns/iter (± 969753) 119653811 ns/iter (± 693924) 1.00
es/full/all/es2017 118967066 ns/iter (± 1706368) 118268733 ns/iter (± 1020463) 1.01
es/full/all/es2018 116706337 ns/iter (± 1317681) 116770773 ns/iter (± 624550) 1.00
es/full/all/es2019 116653735 ns/iter (± 739530) 115796485 ns/iter (± 1113186) 1.01
es/full/all/es2020 111734406 ns/iter (± 511062) 111321688 ns/iter (± 809613) 1.00
es/full/parser 517294 ns/iter (± 10285) 521614 ns/iter (± 11841) 0.99
es/full/base/fixer 21679 ns/iter (± 57) 21782 ns/iter (± 175) 1.00
es/full/base/resolver_and_hygiene 77541 ns/iter (± 203) 77891 ns/iter (± 157) 1.00
serialization of ast node 138 ns/iter (± 1) 139 ns/iter (± 0) 0.99
serialization of serde 122 ns/iter (± 0) 122 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27025790 ns/iter (± 321455) 26835894 ns/iter (± 333214) 1.01
css/visitor/compare/clone 2121108 ns/iter (± 15563) 2082861 ns/iter (± 21612) 1.02
css/visitor/compare/visit_mut_span 2276283 ns/iter (± 11115) 2296677 ns/iter (± 18620) 0.99
css/visitor/compare/visit_mut_span_panic 2329476 ns/iter (± 18512) 2336098 ns/iter (± 18920) 1.00
css/visitor/compare/fold_span 3011338 ns/iter (± 15026) 2974304 ns/iter (± 28450) 1.01
css/visitor/compare/fold_span_panic 3132144 ns/iter (± 29223) 3162460 ns/iter (± 35693) 0.99
css/lexer/bootstrap_5_1_3 5353745 ns/iter (± 23865) 5348919 ns/iter (± 25103) 1.00
css/lexer/foundation_6_7_4 4596958 ns/iter (± 17236) 4488975 ns/iter (± 17715) 1.02
css/lexer/tailwind_3_1_1 876384 ns/iter (± 6026) 850948 ns/iter (± 7008) 1.03
css/parser/bootstrap_5_1_3 20897174 ns/iter (± 166481) 20742584 ns/iter (± 339370) 1.01
css/parser/foundation_6_7_4 16650428 ns/iter (± 140163) 16609238 ns/iter (± 308728) 1.00
css/parser/tailwind_3_1_1 3213293 ns/iter (± 7781) 3194584 ns/iter (± 32584) 1.01
es/codegen/colors 323654 ns/iter (± 182519) 327112 ns/iter (± 185728) 0.99
es/codegen/large 1219054 ns/iter (± 650106) 1224025 ns/iter (± 640142) 1.00
es/codegen/with-parser/colors 46264 ns/iter (± 318) 45894 ns/iter (± 308) 1.01
es/codegen/with-parser/large 507227 ns/iter (± 2445) 501820 ns/iter (± 4415) 1.01
es/minify/libraries/antd 1508966446 ns/iter (± 25387148) 1500527482 ns/iter (± 29685870) 1.01
es/minify/libraries/d3 293875898 ns/iter (± 5505164) 290585028 ns/iter (± 8666602) 1.01
es/minify/libraries/echarts 1264123931 ns/iter (± 29215154) 1246049819 ns/iter (± 22585739) 1.01
es/minify/libraries/jquery 78861910 ns/iter (± 616854) 78479007 ns/iter (± 1003676) 1.00
es/minify/libraries/lodash 97894842 ns/iter (± 1290639) 95484765 ns/iter (± 1137704) 1.03
es/minify/libraries/moment 46101488 ns/iter (± 353631) 45831758 ns/iter (± 548141) 1.01
es/minify/libraries/react 17466303 ns/iter (± 142039) 17215168 ns/iter (± 145684) 1.01
es/minify/libraries/terser 224137054 ns/iter (± 6709622) 224202434 ns/iter (± 4873898) 1.00
es/minify/libraries/three 414068292 ns/iter (± 13181089) 399399089 ns/iter (± 14725106) 1.04
es/minify/libraries/typescript 2824451435 ns/iter (± 17670635) 2802558942 ns/iter (± 10930130) 1.01
es/minify/libraries/victory 589868443 ns/iter (± 18443268) 586343293 ns/iter (± 27090092) 1.01
es/minify/libraries/vue 119637200 ns/iter (± 2854137) 118338808 ns/iter (± 2443965) 1.01
es/visitor/compare/clone 2387105 ns/iter (± 11714) 2379850 ns/iter (± 27514) 1.00
es/visitor/compare/visit_mut_span 2779175 ns/iter (± 24023) 2749505 ns/iter (± 18278) 1.01
es/visitor/compare/visit_mut_span_panic 2844005 ns/iter (± 18425) 2815817 ns/iter (± 19861) 1.01
es/visitor/compare/fold_span 3905703 ns/iter (± 31597) 3934805 ns/iter (± 38068) 0.99
es/visitor/compare/fold_span_panic 4056121 ns/iter (± 24260) 4025965 ns/iter (± 50706) 1.01
es/lexer/colors 17324 ns/iter (± 34) 17280 ns/iter (± 155) 1.00
es/lexer/angular 8191905 ns/iter (± 16205) 8255460 ns/iter (± 53206) 0.99
es/lexer/backbone 1064258 ns/iter (± 5843) 1081418 ns/iter (± 7930) 0.98
es/lexer/jquery 5935251 ns/iter (± 22441) 5951739 ns/iter (± 60010) 1.00
es/lexer/jquery mobile 9144128 ns/iter (± 42685) 9239798 ns/iter (± 36040) 0.99
es/lexer/mootools 4628270 ns/iter (± 35529) 4679937 ns/iter (± 33181) 0.99
es/lexer/underscore 883905 ns/iter (± 8061) 898946 ns/iter (± 6831) 0.98
es/lexer/three 27759427 ns/iter (± 179021) 27912753 ns/iter (± 237036) 0.99
es/lexer/yui 5041604 ns/iter (± 13939) 5065400 ns/iter (± 51523) 1.00
es/parser/colors 31361 ns/iter (± 256) 31187 ns/iter (± 314) 1.01
es/parser/angular 16006655 ns/iter (± 267961) 16161543 ns/iter (± 396697) 0.99
es/parser/backbone 2308074 ns/iter (± 22680) 2306272 ns/iter (± 23125) 1.00
es/parser/jquery 12628818 ns/iter (± 107975) 12516670 ns/iter (± 87519) 1.01
es/parser/jquery mobile 20011850 ns/iter (± 394003) 19803088 ns/iter (± 378210) 1.01
es/parser/mootools 9540374 ns/iter (± 99623) 9480741 ns/iter (± 103353) 1.01
es/parser/underscore 1951391 ns/iter (± 13479) 1957410 ns/iter (± 13384) 1.00
es/parser/three 59967998 ns/iter (± 941557) 58994932 ns/iter (± 1633798) 1.02
es/parser/yui 9688693 ns/iter (± 75413) 9593774 ns/iter (± 84272) 1.01
es/preset-env/usage/builtin_type 141780 ns/iter (± 32278) 140469 ns/iter (± 32147) 1.01
es/preset-env/usage/property 20851 ns/iter (± 125) 21056 ns/iter (± 217) 0.99
es/resolver/typescript 120954766 ns/iter (± 2017252) 119092569 ns/iter (± 2059130) 1.02
es/fixer/typescript 94565340 ns/iter (± 753962) 98067169 ns/iter (± 3284103) 0.96
es/hygiene/typescript 190116255 ns/iter (± 1872375) 194061343 ns/iter (± 2478598) 0.98
es/resolver_with_hygiene/typescript 321608355 ns/iter (± 3714357) 326469574 ns/iter (± 5098563) 0.99
es/visitor/base-perf/module_clone 73525 ns/iter (± 1021) 74844 ns/iter (± 1113) 0.98
es/visitor/base-perf/fold_empty 85466 ns/iter (± 626) 85387 ns/iter (± 951) 1.00
es/visitor/base-perf/fold_noop_impl_all 84998 ns/iter (± 1204) 85691 ns/iter (± 1332) 0.99
es/visitor/base-perf/fold_noop_impl_vec 86162 ns/iter (± 2042) 86713 ns/iter (± 931) 0.99
es/visitor/base-perf/boxing_boxed_clone 54 ns/iter (± 0) 53 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 58 ns/iter (± 0) 58 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 99 ns/iter (± 0) 101 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_unboxed 100 ns/iter (± 0) 101 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_contains_this 3340 ns/iter (± 62) 3510 ns/iter (± 86) 0.95
es/base/parallel/resolver/typescript 5226910860 ns/iter (± 470240380) 5478287615 ns/iter (± 236301060) 0.95
es/base/parallel/hygiene/typescript 2252211222 ns/iter (± 32429473) 2245587299 ns/iter (± 44418267) 1.00
misc/visitors/time-complexity/time 5 108 ns/iter (± 0) 107 ns/iter (± 1) 1.01
misc/visitors/time-complexity/time 10 335 ns/iter (± 1) 360 ns/iter (± 4) 0.93
misc/visitors/time-complexity/time 15 706 ns/iter (± 1) 709 ns/iter (± 12) 1.00
misc/visitors/time-complexity/time 20 1267 ns/iter (± 4) 1285 ns/iter (± 18) 0.99
misc/visitors/time-complexity/time 40 6716 ns/iter (± 34) 6799 ns/iter (± 124) 0.99
misc/visitors/time-complexity/time 60 17375 ns/iter (± 61) 17228 ns/iter (± 137) 1.01
es/full-target/es2016 187836 ns/iter (± 649) 186165 ns/iter (± 1268) 1.01
es/full-target/es2017 180932 ns/iter (± 1035) 180196 ns/iter (± 1178) 1.00
es/full-target/es2018 170989 ns/iter (± 874) 169188 ns/iter (± 1197) 1.01
es2020_nullish_coalescing 65292 ns/iter (± 289) 65427 ns/iter (± 389) 1.00
es2020_optional_chaining 96289 ns/iter (± 7848) 93174 ns/iter (± 798) 1.03
es2022_class_properties 91506 ns/iter (± 628) 92521 ns/iter (± 590) 0.99
es2018_object_rest_spread 69311 ns/iter (± 326) 69446 ns/iter (± 551) 1.00
es2019_optional_catch_binding 59242 ns/iter (± 252) 59618 ns/iter (± 463) 0.99
es2017_async_to_generator 59702 ns/iter (± 338) 59476 ns/iter (± 303) 1.00
es2016_exponentiation 63238 ns/iter (± 210) 63436 ns/iter (± 226) 1.00
es2015_arrow 68326 ns/iter (± 507) 67912 ns/iter (± 577) 1.01
es2015_block_scoped_fn 64368 ns/iter (± 255) 64000 ns/iter (± 385) 1.01
es2015_block_scoping 144718 ns/iter (± 8996) 150081 ns/iter (± 9028) 0.96
es2015_classes 114422 ns/iter (± 610) 114458 ns/iter (± 624) 1.00
es2015_computed_props 59528 ns/iter (± 145) 59511 ns/iter (± 543) 1.00
es2015_destructuring 115429 ns/iter (± 437) 114697 ns/iter (± 646) 1.01
es2015_duplicate_keys 62064 ns/iter (± 310) 62183 ns/iter (± 545) 1.00
es2015_parameters 78276 ns/iter (± 461) 77538 ns/iter (± 487) 1.01
es2015_fn_name 64806 ns/iter (± 491) 65535 ns/iter (± 597) 0.99
es2015_for_of 63070 ns/iter (± 423) 62107 ns/iter (± 529) 1.02
es2015_instanceof 61401 ns/iter (± 197) 61114 ns/iter (± 526) 1.00
es2015_shorthand_property 59096 ns/iter (± 262) 58970 ns/iter (± 700) 1.00
es2015_spread 59745 ns/iter (± 233) 59614 ns/iter (± 471) 1.00
es2015_sticky_regex 60246 ns/iter (± 435) 60875 ns/iter (± 318) 0.99
es2015_typeof_symbol 60550 ns/iter (± 417) 60874 ns/iter (± 510) 0.99
es/transform/baseline/base 50164 ns/iter (± 342) 50095 ns/iter (± 421) 1.00
es/transform/baseline/common_reserved_word 61380 ns/iter (± 499) 61452 ns/iter (± 177) 1.00
es/transform/baseline/common_typescript 170424 ns/iter (± 680) 166055 ns/iter (± 2538) 1.03
es/target/es3 169823 ns/iter (± 864) 165633 ns/iter (± 1162) 1.03
es/target/es2015 630636 ns/iter (± 4646) 624262 ns/iter (± 3260) 1.01
es/target/es2016 63392 ns/iter (± 356) 63469 ns/iter (± 325) 1.00
es/target/es2017 59943 ns/iter (± 274) 59952 ns/iter (± 407) 1.00
es/target/es2018 80247 ns/iter (± 410) 79721 ns/iter (± 851) 1.01
es/target/es2020 132266 ns/iter (± 434) 131273 ns/iter (± 822) 1.01
babelify-only 663489 ns/iter (± 2101) 662692 ns/iter (± 5807) 1.00
parse_and_babelify_angular 43070869 ns/iter (± 927880) 42549324 ns/iter (± 821971) 1.01
parse_and_babelify_backbone 5372379 ns/iter (± 77026) 5319366 ns/iter (± 67920) 1.01
parse_and_babelify_jquery 32882555 ns/iter (± 507013) 32320164 ns/iter (± 707035) 1.02
parse_and_babelify_jquery_mobile 57544830 ns/iter (± 1590600) 56630023 ns/iter (± 962040) 1.02
parse_and_babelify_mootools 34062818 ns/iter (± 835223) 34682362 ns/iter (± 839465) 0.98
parse_and_babelify_underscore 4335142 ns/iter (± 26957) 4293233 ns/iter (± 30207) 1.01
parse_and_babelify_yui 33763907 ns/iter (± 816382) 33776513 ns/iter (± 537958) 1.00
html/minify/document/css_spec 43355114 ns/iter (± 584995) 43468961 ns/iter (± 816980) 1.00
html/minify/document/github 18229095 ns/iter (± 141975) 18320786 ns/iter (± 168972) 0.99
html/minify/document/stackoverflow 16168598 ns/iter (± 121330) 16005908 ns/iter (± 208288) 1.01
html/minify/document_fragment/css_spec 41932685 ns/iter (± 681197) 40823681 ns/iter (± 746690) 1.03
html/minify/document_fragment/github 17760144 ns/iter (± 181667) 17746989 ns/iter (± 139079) 1.00
html/minify/document_fragment/stackoverflow 15827684 ns/iter (± 184500) 15672509 ns/iter (± 168390) 1.01
html/document/visitor/compare/clone 335933 ns/iter (± 2147) 341519 ns/iter (± 3201) 0.98
html/document/visitor/compare/visit_mut_span 369424 ns/iter (± 3274) 364361 ns/iter (± 2342) 1.01
html/document/visitor/compare/visit_mut_span_panic 375831 ns/iter (± 2012) 373233 ns/iter (± 3603) 1.01
html/document/visitor/compare/fold_span 406391 ns/iter (± 2953) 399073 ns/iter (± 2959) 1.02
html/document/visitor/compare/fold_span_panic 460071 ns/iter (± 2401) 458838 ns/iter (± 4365) 1.00
html/document_fragment/visitor/compare/clone 342391 ns/iter (± 1967) 332419 ns/iter (± 3075) 1.03
html/document_fragment/visitor/compare/visit_mut_span 365827 ns/iter (± 1558) 367344 ns/iter (± 2754) 1.00
html/document_fragment/visitor/compare/visit_mut_span_panic 373385 ns/iter (± 2692) 368594 ns/iter (± 3504) 1.01
html/document_fragment/visitor/compare/fold_span 400254 ns/iter (± 3182) 403859 ns/iter (± 4430) 0.99
html/document_fragment/visitor/compare/fold_span_panic 464724 ns/iter (± 6230) 455922 ns/iter (± 4171) 1.02
html/lexer/css_2021_spec 15579052 ns/iter (± 31513) 15496162 ns/iter (± 65789) 1.01
html/lexer/github_com_17_05_2022 6055029 ns/iter (± 7655) 6035600 ns/iter (± 35254) 1.00
html/lexer/stackoverflow_com_17_05_2022 5652120 ns/iter (± 16685) 5617151 ns/iter (± 27386) 1.01
html/parser/parser_document/css_2021_spec 26204314 ns/iter (± 419392) 25692236 ns/iter (± 495037) 1.02
html/parser/parser_document/github_com_17_05_2022 8834222 ns/iter (± 15244) 8719579 ns/iter (± 60042) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7774419 ns/iter (± 24946) 7714926 ns/iter (± 59716) 1.01
html/parser/parser_document_fragment/css_2021_spec 25863676 ns/iter (± 421644) 25425651 ns/iter (± 349878) 1.02
html/parser/parser_document_fragment/github_com_17_05_2022 8719279 ns/iter (± 62251) 8734426 ns/iter (± 76689) 1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7743735 ns/iter (± 34958) 7707978 ns/iter (± 66502) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.