fix(es/parser): Report errors for multiple import/export specifiers w…

…ithout comma (#2302)
swc-project · Sep 25, 2021 · 83153a0 · 83153a0
1 parent 83d88ce
commit 83153a0
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 17 deletions.
diff --git a/ecmascript/parser/src/parser/stmt/module_item.rs b/ecmascript/parser/src/parser/stmt/module_item.rs
@@ -118,15 +118,14 @@ impl<'a, I: Tokens> Parser<I> {
                     local,
                 }));
             } else if eat!(self, '{') {
-                let mut first = true;
                 while !eof!(self) && !is!(self, '}') {
-                    if first {
-                        first = false;
-                    } else if eat!(self, ',') && is!(self, '}') {
+                    specifiers.push(self.parse_import_specifier()?);
+
+                    if is!(self, '}') {
                         break;
+                    } else {
+                        expect!(self, ',');
                     }
-
-                    specifiers.push(self.parse_import_specifier()?);
                 }
                 expect!(self, '}');
             }
@@ -513,18 +512,17 @@ impl<'a, I: Tokens> Parser<I> {
                     exported: default,
                 }))
             }
-            let mut first = true;
-            while is_one_of!(self, ',', IdentName) {
-                if first {
-                    first = false;
-                } else if eat!(self, ',') && is!(self, '}') {
-                    break;
-                }
-
+            while !eof!(self) && !is!(self, '}') {
                 specifiers.push(
                     self.parse_named_export_specifier()
                         .map(ExportSpecifier::Named)?,
                 );
+
+                if is!(self, '}') {
+                    break;
+                } else {
+                    expect!(self, ',');
+                }
             }
             expect!(self, '}');
 

diff --git a/ecmascript/parser/tests/test262-error-references/fail/26c0710a6449872a.module.js.stderr b/ecmascript/parser/tests/test262-error-references/fail/26c0710a6449872a.module.js.stderr
@@ -1,6 +1,6 @@
-error: Unexpected token `a`. Expected a string literal
- --> $DIR/tests/test262-parser/fail/26c0710a6449872a.module.js:1:20
+error: Expected ,, got b
+ --> $DIR/tests/test262-parser/fail/26c0710a6449872a.module.js:1:12
   |
 1 | export {as b} from a
-  |                    ^
+  |            ^
 
diff --git a/ecmascript/parser/tests/typescript-errors/multiple-specifiers/export/input.ts b/ecmascript/parser/tests/typescript-errors/multiple-specifiers/export/input.ts
@@ -0,0 +1 @@
+export { a b c }
diff --git a/ecmascript/parser/tests/typescript-errors/multiple-specifiers/export/input.ts.stderr b/ecmascript/parser/tests/typescript-errors/multiple-specifiers/export/input.ts.stderr
@@ -0,0 +1,6 @@
+error: Expected ,, got b
+ --> $DIR/tests/typescript-errors/multiple-specifiers/export/input.ts:1:12
+  |
+1 | export { a b c }
+  |            ^
+
diff --git a/ecmascript/parser/tests/typescript-errors/multiple-specifiers/import/input.ts b/ecmascript/parser/tests/typescript-errors/multiple-specifiers/import/input.ts
@@ -0,0 +1 @@
+import { a b c } from 'mod'
diff --git a/ecmascript/parser/tests/typescript-errors/multiple-specifiers/import/input.ts.stderr b/ecmascript/parser/tests/typescript-errors/multiple-specifiers/import/input.ts.stderr
@@ -0,0 +1,6 @@
+error: Expected ,, got b
+ --> $DIR/tests/typescript-errors/multiple-specifiers/import/input.ts:1:12
+  |
+1 | import { a b c } from 'mod'
+  |            ^
+